Skip to content

fix: MySQL 8.2+ and mysql:8 failing to start - #111

Merged
AaronFeledy merged 6 commits into
mainfrom
fix/mysql-8.4-startup
Oct 15, 2026
Merged

AaronFeledy merged 6 commits into
mainfrom
fix/mysql-8.4-startup

Conversation

@AaronFeledy

@AaronFeledy AaronFeledy commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

MySQL 8.2 removed expire_logs_days, but the recipe's MySQL 8 config still sets it, so mysql:8.2, 8.3 and 8.4 abort on startup with unknown variable 'expire_logs_days=10'. The bare mysql:8 alias (MySQL 8.4.5) was also loading the 5.7 config file and failing on query_cache_limit.

  • Replace expire_logs_days = 10 with binlog_expire_logs_seconds = 864000: same 10 days, supported since MySQL 8.0.1
  • Send mysql:8 to the MySQL 8 config
  • Add examples/lamp-mysql84 on mysql:8 to CI

Verified locally on Lando 3.26.9: lando start with database: mysql:8 boots MySQL 8.4.5 with the MySQL 8 config and binlog_expire_logs_seconds=864000.

Alternative to #108, which deletes the line instead, so binlog retention falls back to MySQL's 30-day default. This keeps 10 days.

Same bug as lando/laravel#114.


Note

Medium Risk
Changes default MySQL config selection and shipped mysql8.cnf settings, which can affect database container startup for all MySQL 8.x LAMP apps.

Overview
Fixes LAMP stacks where MySQL 8.2+ or the mysql:8 alias would fail on startup because of outdated config and version routing.

config/mysql8.cnf now sets binlog_expire_logs_seconds = 864000 instead of the removed expire_logs_days, preserving a 10-day binlog retention on MySQL 8.2+.

builders/lamp.js treats any 8.x database version (_.startsWith(version, '8')) as MySQL 8 so bare mysql:8 gets mysql8.cnf rather than the 5.7 mysql.cnf.

CI adds examples/lamp-mysql84 (Leia tests on database=mysql:8) and pins lando/run-leia-action to 1.0.0-beta.4. The unreleased CHANGELOG documents both fixes.

Reviewed by Cursor Bugbot for commit e2f420a. Bugbot is set up for automated code reviews on this repo. Configure here.

@netlify

netlify Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for lando-lamp ready!

Name Link
🔨 Latest commit e2f420a
🔍 Latest deploy log https://app.netlify.com/projects/lando-lamp/deploys/6ad0bbe3617f1c08307a6f70
😎 Deploy Preview https://deploy-preview-111--lando-lamp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 90 (🔴 down 2 from production)
Accessibility: 96 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@AaronFeledy
AaronFeledy merged commit f6aeaa8 into main Oct 15, 2026
34 checks passed
@AaronFeledy
AaronFeledy deleted the fix/mysql-8.4-startup branch October 15, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant