Repository navigation
Conversation
Contributor
|
Skipping CI for Draft Pull Request. |
✅ Deploy Preview for dra-driver-nvidia-gpu canceled.
|
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: harche The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
harche
force-pushed
the
kep-4680-device-health-status
branch
from
October 5, 2026 17:26
46699ac to
3ec0e31
Compare
harche
force-pushed
the
kep-4680-device-health-status
branch
2 times, most recently
from
October 5, 2026 17:35
932e273 to
a3c10b3
Compare
Implement WatchHealthStatus so the kubelet can surface the health of allocated GPUs in pod.status.containerStatuses[].allocatedResourcesStatus. Health is derived from the device taints the NVML health monitor already publishes in the ResourceSlice, so the pod status and the scheduler see the same classification: fatal XIDs and GPU loss are Unhealthy, unmonitored devices are Unknown, non-fatal XIDs stay Healthy with a message. Reports are sent on subscribe, on every taint change and every 10 seconds, and never wait behind a Prepare or Unprepare holding the device state lock. The DRAResourceHealth service is only advertised when the NVML health monitor runs (NVMLDeviceHealthCheck). Move the GCP nvkind e2e harness to Kubernetes 1.37, where ResourceHealthStatus is on by default: use kind v0.33.0 (kubeadm v1beta4) and rebuild nvkind at main (NVIDIA/nvkind#76, nvidia-ctk --config-source=file) against it. Also keep macOS tar from adding AppleDouble files that Helm fails to parse as CRDs. Bump the mock NVML (NVIDIA/k8s-test-infra) to 57ef0165, which delivers injected XID events to NVML health monitors (NVIDIA/k8s-test-infra#735), and emulate 4 GPUs to match its 4-GPU gb200 profile; GPUs beyond the profile get a random UUID per process, so nvidia-smi cannot find them.
harche
force-pushed
the
kep-4680-device-health-status
branch
from
October 5, 2026 17:37
a3c10b3 to
4e9f612
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Implements KEP-4680 (DRA device health status) for the GPU kubelet plugin, following #1243 (comment).
Which issue(s) this PR is related to:
Supersedes #1243.
Special notes for your reviewer:
Two additional changes were needed to test this. Should they stay in this PR or go into separate ones?
main. The current harness can't create 1.36+ clusters.k8s-test-infrato57ef0165withGPU_COUNT=4. The current pin doesn't deliver injected XIDs, which the new mock-NVML bats test needs.AI disclosure: an AI coding assistant helped write this change.
Does this PR introduce a user-facing change?
Additional documentation (design docs, usage docs, etc.):