Repository navigation
Conversation
Kubernetes 1.37 dropped the kubeadm v1beta3 config that kind v0.31.0 generates, and newer kindest/node images ship a containerd that fails to restart with the drop-in nvidia-ctk writes from --config-source=command. Use kind v0.33.0 and rebuild nvkind at main, which includes NVIDIA/nvkind#76, against it. Also keep macOS tar from adding AppleDouble files to the source tarball; Helm fails to parse them as CRDs on local runs from a Mac.
Contributor
|
Skipping CI for Draft Pull Request. |
✅ Deploy Preview for dra-driver-nvidia-gpu canceled.
|
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: harche The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
Folded into #1525. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Moves the GCP nvkind e2e harness (
hack/ci/gcp-nvkind) from Kubernetes 1.34 to 1.37 so it can exercise newer kubelet features, such as DRA device health status (KEP-4680,ResourceHealthStatus, beta and on by default since 1.36), without extra feature gates.Changing only
K8S_VERSIONisn't enough; two tooling issues block newer node images:kubeadm.k8s.io/v1beta3config. kubeadm 1.37 rejects it ("Please use kubeadm v1.36 instead"). kind v0.32.0+ generatesv1beta4for 1.36+. This PR installs kind v0.33.0 and rebuilds nvkind against it, since nvkind still vendors v0.31.0 (Bump sigs.k8s.io/kind from 0.31.0 to 0.32.0 NVIDIA/nvkind#75 is open to bump it).nvidia-ctk runtime configure --config-source=commandwrites a drop-in that containerd fails to restart with. Update nvidia-ctk --config-source flag from 'command' to 'file' NVIDIA/nvkind#76 switched to--config-source=file. This PR pins nvkind toc5705049(currentmain), which includes it.It also sets
COPYFILE_DISABLE=1and excludes._*when packing the source. Without that, macOStaradds AppleDouble files, and on a local run from a Mac, Helm fails parsingcrds/._*.yamlas CRDs. Prow runs on Linux and is unaffected.Which issue(s) this PR is related to:
N/A. Found while testing the KEP-4680 device health reporting rework (follow-up to #1243) on a real GPU.
Special notes for your reviewer:
lib/inkubernetes/test-infra(experiment/gcp-nvkind/lib/) and setsK8S_VERSIONin the job config. For the Prow job to pick this up,setup-nvkind-node.shandK8S_VERSIONneed the matching change there. I'll send that once this direction is agreed.us-central1-b): nvkind cluster onkindest/node:v1.37.0, GPU Operatorv26.3.1, driver built from source, and the Ginkgo suite passed (8/8).kubeadm initfails; on 1.36.4 with the current nvkind, containerd fails to restart.Does this PR introduce a user-facing change?
Additional documentation (design docs, usage docs, etc.):