Skip to content

CLM: Reminders for potentially outdated content#330

Open
jnptk wants to merge 112 commits into
mainfrom
content-review
Open

CLM: Reminders for potentially outdated content#330
jnptk wants to merge 112 commits into
mainfrom
content-review

Conversation

@jnptk

@jnptk jnptk commented Feb 13, 2026

Copy link
Copy Markdown
Member

@jnptk jnptk requested a review from davisagli February 13, 2026 15:57
Comment thread backend/src/kitconcept/intranet/behaviors/content_review.py
Comment thread backend/src/kitconcept/intranet/behaviors/content_review.py
Comment thread backend/src/kitconcept/intranet/behaviors/content_review.py Outdated
@provider(IVocabularyFactory)
def review_users_vocabulary(context):
acl_users = context.acl_users
reviewers = acl_users.getGroupById("Reviewers")

@davisagli davisagli Feb 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This group doesn't exist (I think?). For the first implementation I would make the field use the plone.app.vocabularies.Users vocabulary so any user can be selected. Then we can come back and make it smarter later.

You can use plone.api for this: https://6.docs.plone.org/plone.api/group.html#get-group-members

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davisagli "Reviewers" is correct. plone.api.user.get_users(groupname="Reviewers") returns all members of this group. Should I use SimpleVocabulary([SimpleTerm]) here as well?

Comment thread backend/src/kitconcept/intranet/controlpanels/intranet.py
Comment thread backend/src/kitconcept/intranet/services/configure.zcml Outdated
Comment thread backend/src/kitconcept/intranet/services/configure.zcml Outdated
Comment thread backend/src/kitconcept/intranet/services/review.py Outdated
Comment thread backend/src/kitconcept/intranet/services/review.py Outdated
Comment thread backend/src/kitconcept/intranet/services/review.py
Comment thread backend/src/kitconcept/intranet/services/review.py Outdated
Comment thread backend/src/kitconcept/intranet/profiles/default/registry/querystring.xml Outdated
@Tishasoumya-02 Tishasoumya-02 requested a review from iFlameing June 4, 2026 11:22
@Tishasoumya-02

Copy link
Copy Markdown
Contributor

UI now:

Screenshot 2026-06-04 at 4 52 59 PM

@iFlameing iFlameing left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked into the implementation, and it looks good to me for a POC. There is room for improvement in design, but as a starting point, I think it is good.

@davisagli

Copy link
Copy Markdown
Member

@Tishasoumya-02 Thanks for updating it to use pluggables so we don't have to override so many components.

@iFlameing @Tishasoumya-02 This is in a pretty good state for a proof of concept. We should try to ship it to dev so that we can get feedback from Dominique. There are two things I think we should do first:

  1. We should add a global setting to enable/disable this feature. That way we can test it out without enabling it for all clients until we are ready.
  2. We need a daily cron job to actually run the script that sends the reminders. I can set this up tomorrow.

We will also need documentation for this feature, but maybe we should get initial feedback from Dominique before we spend time on that, in case we need to change something.

/cc @danalvrz

@jnptk jnptk requested a review from a team as a code owner June 15, 2026 13:58
@jnptk jnptk removed the request for review from a team June 16, 2026 07:02
@iFlameing

Copy link
Copy Markdown
Member

@davisagli if you have time please do the final review :)

Comment thread devops/stacks/demo.yml Outdated
Comment thread devops/stacks/persistent.yml Outdated
Comment thread devops/stacks/persistent.yml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants