CLM: Reminders for potentially outdated content#330
Conversation
| @provider(IVocabularyFactory) | ||
| def review_users_vocabulary(context): | ||
| acl_users = context.acl_users | ||
| reviewers = acl_users.getGroupById("Reviewers") |
There was a problem hiding this comment.
This group doesn't exist (I think?). For the first implementation I would make the field use the plone.app.vocabularies.Users vocabulary so any user can be selected. Then we can come back and make it smarter later.
You can use plone.api for this: https://6.docs.plone.org/plone.api/group.html#get-group-members
There was a problem hiding this comment.
@davisagli "Reviewers" is correct. plone.api.user.get_users(groupname="Reviewers") returns all members of this group. Should I use SimpleVocabulary([SimpleTerm]) here as well?
iFlameing
left a comment
There was a problem hiding this comment.
I looked into the implementation, and it looks good to me for a POC. There is room for improvement in design, but as a starting point, I think it is good.
|
@Tishasoumya-02 Thanks for updating it to use pluggables so we don't have to override so many components. @iFlameing @Tishasoumya-02 This is in a pretty good state for a proof of concept. We should try to ship it to dev so that we can get feedback from Dominique. There are two things I think we should do first:
We will also need documentation for this feature, but maybe we should get initial feedback from Dominique before we spend time on that, in case we need to change something. /cc @danalvrz |
|
@davisagli if you have time please do the final review :) |

https://gitlab.kitconcept.io/kitconcept/distribution-kitconcept-intranet/-/issues/216