test(printer): isolate color environment and verify opt-out - #39
Open
rupayon123 wants to merge 1 commit into
Open
test(printer): isolate color environment and verify opt-out#39rupayon123 wants to merge 1 commit into
rupayon123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Color-output tests fail when a contributor runs the suite from a shell with
NO_COLOR=1, even though suppressing color is the intended behavior.Give the two ANSI assertions their own empty
NO_COLORsetting usingt.Setenv, and add JSON/HTML tests proving a nonemptyNO_COLORsuppresses ANSI even when formatting requests color. Product behavior is unchanged, and the environment is restored automatically after each test.Validation: reproduced both original failures with
NO_COLOR=1 go test ./printer -count=1. Afterward the full suite passes withNO_COLOR=1, printer tests also pass with the variable unset, andgo vet ./..., build and diff checks pass. golangci-lint is unavailable locally; remote CI will be checked separately. Prepared with AI assistance.