fix(printer): preserve JSON and HTML response content - #40
Open
rupayon123 wants to merge 7 commits into
Open
rupayon123 wants to merge 7 commits into
rupayon123 wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
Preserve JSON and HTML response content during formatting. JSON keys and string values are escaped correctly, actual written byte counts include partial writes, and trailing documents/junk/read errors are reported rather than silently ignored. HTML formatting preserves script/style raw text, namespace-qualified attributes, and preformatted whitespace, including a leading newline.
Response selection now parses the media type itself: structured +json and XHTML bodies reach their formatters instead of being hidden as binary data, and a MIME parameter cannot accidentally select the JSON or HTML formatter.
Validation
Focused regressions reproduced every original failure. Full env -u NO_COLOR go test ./..., go vet ./..., builds, formatting and git diff --check pass. Regression cases include JSON round trips and failing writers/readers, HTML parse-format-parse content comparisons, namespaced attributes, and response media-type dispatch. Color environment isolation is submitted separately in PR39. golangci-lint was not run locally.
Prepared with AI assistance. Remote CI is verified separately on the latest head; passing checks do not imply maintainer approval.