Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

fix potential class/struct odr violations, and fix 32-bit shift #57

Merged
jll63 merged 2 commits into from
Feb 1, 2026
Merged

fix potential class/struct odr violations, and fix 32-bit shift #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc547d5
fix potential class/struct odr violations
iboB Sep 2, 2025
c0c0691
fix 32-bit shift
iboB Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/yorel/yomm2/policies/core.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ struct domain {};
} // namespace detail

template<class Class, class Policy>
struct virtual_ptr;
class virtual_ptr;

template<typename T>
struct virtual_;
Expand Down
2 changes: 1 addition & 1 deletion include/yorel/yomm2/policies/fast_perfect_hash.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ void fast_perfect_hash<Policy>::hash_initialize(
hash_search_error error;
error.attempts = total_attempts;
// error.duration = std::chrono::steady_clock::now() - start_time;
error.buckets = 1 << M;
error.buckets = size_t(1) << M;

if constexpr (has_facet<Policy, error_handler>) {
Policy::error(error_type(error));
Expand Down
20 changes: 10 additions & 10 deletions include/yorel/yomm2/policy.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,20 +95,20 @@ struct yOMM2_API_gcc debug
backward_compatible_error_handler<debug>> {};

#if defined(_MSC_VER) && !defined(yOMM2_DLL)
extern template class __declspec(dllimport) basic_domain<debug_shared>;
extern template class __declspec(dllimport) vptr_vector<debug_shared>;
extern template class __declspec(dllimport)
extern template struct __declspec(dllimport) basic_domain<debug_shared>;
extern template struct __declspec(dllimport) vptr_vector<debug_shared>;
extern template struct __declspec(dllimport)
vectored_error<debug_shared, backward_compatible_error_handler<debug_shared>>;
extern template class __declspec(dllimport) fast_perfect_hash<debug_shared>;
extern template class __declspec(dllimport) checked_perfect_hash<debug_shared>;
extern template class __declspec(dllimport)
extern template struct __declspec(dllimport) fast_perfect_hash<debug_shared>;
extern template struct __declspec(dllimport) checked_perfect_hash<debug_shared>;
extern template struct __declspec(dllimport)
basic_trace_output<debug_shared, detail::ostderr>;
extern template class __declspec(dllimport)
extern template struct __declspec(dllimport)
basic_error_output<debug_shared, detail::ostderr>;
extern template class __declspec(dllimport) checked_perfect_hash<debug_shared>;
extern template class __declspec(dllimport)
extern template struct __declspec(dllimport) checked_perfect_hash<debug_shared>;
extern template struct __declspec(dllimport)
backward_compatible_error_handler<debug_shared>;
extern template class __declspec(dllimport) basic_policy<
extern template struct __declspec(dllimport) basic_policy<
debug_shared, vptr_vector<debug_shared>, std_rtti,
checked_perfect_hash<debug_shared>, basic_error_output<debug_shared>,
basic_trace_output<debug_shared>,
Expand Down
20 changes: 10 additions & 10 deletions src/yomm2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,17 @@ namespace policy {

//std::vector<type_id> checked_perfect_hash<debug_shared>::control;

template class yOMM2_API_msc basic_domain<debug_shared>;
template class yOMM2_API_msc vptr_vector<debug_shared>;
template class yOMM2_API_msc basic_indirect_vptr<debug_shared>;
template class yOMM2_API_msc vectored_error<
template struct yOMM2_API_msc basic_domain<debug_shared>;
template struct yOMM2_API_msc vptr_vector<debug_shared>;
template struct yOMM2_API_msc basic_indirect_vptr<debug_shared>;
template struct yOMM2_API_msc vectored_error<
debug_shared, backward_compatible_error_handler<debug_shared>>;
template class yOMM2_API_msc backward_compatible_error_handler<debug_shared>;
template class yOMM2_API_msc fast_perfect_hash<debug_shared>;
template class yOMM2_API_msc checked_perfect_hash<debug_shared>;
template class yOMM2_API_msc basic_error_output<debug_shared>;
template class yOMM2_API_msc basic_trace_output<debug_shared>;
template class yOMM2_API_msc basic_policy<
template struct yOMM2_API_msc backward_compatible_error_handler<debug_shared>;
template struct yOMM2_API_msc fast_perfect_hash<debug_shared>;
template struct yOMM2_API_msc checked_perfect_hash<debug_shared>;
template struct yOMM2_API_msc basic_error_output<debug_shared>;
template struct yOMM2_API_msc basic_trace_output<debug_shared>;
template struct yOMM2_API_msc basic_policy<
debug_shared, std_rtti, checked_perfect_hash<debug_shared>,
basic_error_output<debug_shared>, basic_trace_output<debug_shared>,
backward_compatible_error_handler<debug_shared>>;
Expand Down
Loading