This repository was archived by the owner on Mar 4, 2026. It is now read-only.
fix potential class/struct odr violations, and fix 32-bit shift#57
Merged
jll63 merged 2 commits intojll63:masterfrom Feb 1, 2026
Merged
fix potential class/struct odr violations, and fix 32-bit shift#57jll63 merged 2 commits intojll63:masterfrom
jll63 merged 2 commits intojll63:masterfrom
Conversation
Owner
|
Sorry I just noticed this. I was busy with transforming YOMM2 into Boost.OpenMethod. I am about to announce (on reddit) that I am retiring YOMM2 - but my work on open methods continue of course! Thanks for the PR though. Please consider moving on to Boost.OpenMethod! |
jll63
approved these changes
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits in this PR:
1 << Mis a 32-bit shift. So, even thoughMandbucketswill be 64-bit (size_t) on a x64 system, whenMis 32 or more, UB will ensue.