-
-
Notifications
You must be signed in to change notification settings - Fork 364
Spelling #1614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Spelling #1614
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
71924bc
spelling: appropriately
jsoref 9b6f8e5
spelling: its
jsoref ed8f879
spelling: kentcdodds
jsoref c2041a4
spelling: set up
jsoref 0ca11ae
spelling: should
jsoref d1582f8
spelling: support
jsoref 5e40197
spelling: version
jsoref 4d27f31
spelling: workaround
jsoref File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -258,7 +258,7 @@ nyc --require esm mocha | |
| ### Interaction with `--all` flag | ||
|
|
||
| The `--require` flag also operates on the main nyc process for use by `--all`. | ||
| For example, in situations with `nyc --all --instrument false` and [`babel-plugin-istanbul`] setup the `--all` option only works if `--require @babel/register` is passed to nyc. | ||
| For example, in situations with `nyc --all --instrument false` and [`babel-plugin-istanbul`] set up the `--all` option only works if `--require @babel/register` is passed to nyc. | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This required thinking through the part of speech. I think I'm right, for |
||
| Passing it to mocha would cause the tests to be instrumented but unloaded sources would not be seen. | ||
| The [`@istanbuljs/nyc-config-babel`] package handles this for you! | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kinda fun. I had to look up the handle to confirm which was right