Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,7 @@ files.

### Bug Fixes

* introduced a bug that resulted in source-maps not being loaded approriately on second test run ([#566](https://github.com/istanbuljs/nyc/issues/566)) ([1bf74fd](https://github.com/istanbuljs/nyc/commit/1bf74fd))
* introduced a bug that resulted in source-maps not being loaded appropriately on second test run ([#566](https://github.com/istanbuljs/nyc/issues/566)) ([1bf74fd](https://github.com/istanbuljs/nyc/commit/1bf74fd))



Expand Down Expand Up @@ -726,7 +726,7 @@ files.

### Features

* upgrade to new test-exclude; with suppport for node_modules, and empty exclude ([#348](https://github.com/bcoe/nyc/issues/348)) ([d616ffc](https://github.com/bcoe/nyc/commit/d616ffc))
* upgrade to new test-exclude; with support for node_modules, and empty exclude ([#348](https://github.com/bcoe/nyc/issues/348)) ([d616ffc](https://github.com/bcoe/nyc/commit/d616ffc))


### BREAKING CHANGES
Expand All @@ -742,7 +742,7 @@ files.
### Bug Fixes

* make --all flag work with files with extensions other than .js ([#326](https://github.com/bcoe/nyc/issues/326)) ([d0a8674](https://github.com/bcoe/nyc/commit/d0a8674))
* work around for Windows path issue nodejs/node[#6624](https://github.com/bcoe/nyc/issues/6624) ([6b1fed0](https://github.com/bcoe/nyc/commit/6b1fed0))
* workaround for Windows path issue nodejs/node[#6624](https://github.com/bcoe/nyc/issues/6624) ([6b1fed0](https://github.com/bcoe/nyc/commit/6b1fed0))


### Features
Expand Down Expand Up @@ -882,7 +882,7 @@ files.

### Features

* better docs for excluding, thanks @kentdodds \o/ ([22b06fe](https://github.com/bcoe/nyc/commit/22b06fe))
* better docs for excluding, thanks @kentcdodds \o/ ([22b06fe](https://github.com/bcoe/nyc/commit/22b06fe))
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda fun. I had to look up the handle to confirm which was right

* updating dependencies (spawn wrap with npm patches \o/) ([ac841b8](https://github.com/bcoe/nyc/commit/ac841b8))


Expand Down Expand Up @@ -920,7 +920,7 @@ files.

### v6.1.0 (2016/03/12 15:00 +7:00)

- [#191](https://github.com/bcoe/nyc/pull/191) upgrade to non-singleton verison of yargs (@bcoe)
- [#191](https://github.com/bcoe/nyc/pull/191) upgrade to non-singleton version of yargs (@bcoe)
- [#185](https://github.com/bcoe/nyc/pull/185) default to long-form option names so that they can be overridden in package.json (@rapzo)
- [#180](https://github.com/bcoe/nyc/pull/180) fix bug with findUp (@bcoe)
- [#178](https://github.com/bcoe/nyc/pull/178) --all should handle extensions other than .js. (@lloydcotten)
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ nyc --require esm mocha
### Interaction with `--all` flag

The `--require` flag also operates on the main nyc process for use by `--all`.
For example, in situations with `nyc --all --instrument false` and [`babel-plugin-istanbul`] setup the `--all` option only works if `--require @babel/register` is passed to nyc.
For example, in situations with `nyc --all --instrument false` and [`babel-plugin-istanbul`] set up the `--all` option only works if `--require @babel/register` is passed to nyc.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This required thinking through the part of speech. I think I'm right, for setup, I'd expect to see an article the/a/an somewhere.

Passing it to mocha would cause the tests to be instrumented but unloaded sources would not be seen.
The [`@istanbuljs/nyc-config-babel`] package handles this for you!

Expand Down
2 changes: 1 addition & 1 deletion docs/profiling.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ cd /user/dev/ava
npm link nyc
```

This will likely not work with `tap --coverage`, since tap will try to use it's own older copy of nyc instead of your globally linked one. Modify the test script in your test project so it uses the `nyc` binary directly, and disable `tap`s version with the `--no-cov` flag:
This will likely not work with `tap --coverage`, since tap will try to use its own older copy of nyc instead of your globally linked one. Modify the test script in your test project so it uses the `nyc` binary directly, and disable `tap`s version with the `--no-cov` flag:

`package.json`:

Expand Down
2 changes: 1 addition & 1 deletion test/nyc-integration.js
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ t.test('extracts coverage headers from unexecuted files', async t => {

t.ok(coverage.length !== 0)
t.ok(coverage.every(data => typeof data === 'object'))
// we should not have executed file, so all counts sould be 0.
// we should not have executed file, so all counts should be 0.
t.ok(coverage.every(data => Object.values(data.s).every(s => s === 0)))
})

Expand Down