Feat ppm fragment ion matching#192
Open
JemmaLDaniel wants to merge 6 commits into
Open
Conversation
…or with isotope correction
Base automatically changed from
fix-fragment-match-double-counting
to
feat-refactor-calibration-features
June 19, 2026 10:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch fragment ion matching tolerance from Daltons to PPM
Summary
mz_toleranceparameter (absolute Daltons) onFragmentMatchFeatures,ChimericFeatures,find_matching_ions, andcompute_ion_identificationswith two mutually exclusive keyword-only parameters:mz_tolerance_ppm(relative, parts per million) andmz_tolerance_da(absolute, Daltons). Exactly one must be provided; passing both or neither raisesValueError.calibrator.yaml) now usesmz_tolerance_ppm: 20instead ofmz_tolerance: 0.02, so CLI/Hydra users get 20 ppm matching out of the box. Users who prefer absolute Da tolerance can setmz_tolerance_dainstead.query_mz * ppm / 1e6.