174 feat add mgf file support for mztab data loader#178
Closed
JemmaLDaniel wants to merge 5 commits into
Closed
Conversation
…ZTabDatasetLoader
… for MZTabDatasetLoader
BioGeek
requested changes
Jun 8, 2026
| # to search engine output predictions (e.g. Casanovo, InstaNovo). MGF files always receive | ||
| # these columns regardless of this setting. Set to false if your parquet/ipc files already | ||
| # contain a spectrum_id column. | ||
| add_index_cols: true |
Contributor
There was a problem hiding this comment.
I would preserve existing spectrum IDs by default. When users load parquet/ipc spectra through the default data_loader=mztab config and the file already contains a spectrum_id, this new default causes _add_index_cols to overwrite those IDs with {file_stem}:{row}. Downstream prediction/FDR exports key results by spectrum_id, so existing stable identifiers are silently lost unless users discover and override this setting. So keep the default false for parquet/ipc or only fill missing IDs.
Collaborator
Author
There was a problem hiding this comment.
Changed to False and made the docs clearer
Collaborator
Author
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MZTabDatasetLoaderto accept.mgfspectrum files (viamatchms) alongside the existing.parquetand.ipcformatsadd_index_colsparameter (defaulting to true inmztab.yaml) that generatesexperiment_nameandspectrum_idcolumns, enabling downstream features that requirespectrum_id_df_from_matchms,_add_index_cols) fromInstaNovoDatasetLoaderinto module-level functions reused by both loadersThe generated
spectrum_id({file_stem}:{row_index}) aligns with the 0-basedindex=Nextracted from MZTabspectra_ref, so Casanovo and other MZTab-producing engines are correctly mapped to their input spectra without changing the existing join semantics.