Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,11 @@ jobs:
run: dotnet fsi scripts/CheckSolutionVersions.fsx

- name: Publish test results
# continue-on-error: Dependabot PRs (and PRs from forks) get a read-only GITHUB_TOKEN that GitHub forces
# regardless of any `permissions:` blocks declared, so this step 403s on those runs. Test results are still
# in the build log so don't let that fail a good build due to this step.
if: always() && runner.os == 'Linux'
continue-on-error: true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Limit reporting error suppression

continue-on-error applies to every invocation, including trusted pushes and same-repository pull requests where result publication is expected to work. A non-permission failure in this sole publication step will therefore leave annotations absent while CI remains green; limit suppression to the restricted Dependabot and fork contexts.

Knowledge Base Used: Build and Versioning

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

uses: EnricoMi/publish-unit-test-result-action@d0a4676d0e0b938bc201470d88276b7c74c712b3 # v2.24.0
with:
files: '**/TestResults/**/*.trx'