fix(github): don't fail CI when publishing test results is blocked - #430
Conversation
Dependabot and fork PRs get a read-only GitHub token that can't post test-result annotations, which was failing otherwise good builds. If we make that step non-blocking so a permissions issue with a reporting step doesn't mask a good build.
| # regardless of any `permissions:` blocks declared, so this step 403s on those runs. Test results are still | ||
| # in the build log so don't let that fail a good build due to this step. | ||
| if: always() && runner.os == 'Linux' | ||
| continue-on-error: true |
There was a problem hiding this comment.
Limit reporting error suppression
continue-on-error applies to every invocation, including trusted pushes and same-repository pull requests where result publication is expected to work. A non-permission failure in this sole publication step will therefore leave annotations absent while CI remains green; limit suppression to the restricted Dependabot and fork contexts.
Knowledge Base Used: Build and Versioning
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Greptile SummaryMakes GitHub test-result publication non-blocking so permission failures on Dependabot and fork pull requests do not fail otherwise successful builds.
Confidence Score: 4/5The PR is safe to merge, with a non-blocking concern that reporting failures are suppressed beyond the restricted-token contexts targeted by the change. Test execution remains blocking, but unconditional error suppression allows the sole result-publication step to fail silently on trusted pushes and same-repository pull requests. Files Needing Attention: .github/workflows/build.yml Important Files Changed
Reviews (1): Last reviewed commit: "fix(github): don't fail CI when publishi..." | Re-trigger Greptile |
Dependabot and fork PRs get a read-only GitHub token that can't post test-result annotations, which was failing otherwise good builds.
If we make that step non-blocking so a permissions issue with a reporting step doesn't mask a good build. Fixes #425