Support configuration via env#196
Merged
bknoles merged 2 commits intoinertiajs:masterfrom Mar 4, 2025
Merged
Conversation
a567744 to
dca5702
Compare
Contributor
|
I am sold with this approach. Love your work as always bro @skryukov |
Collaborator
Is this the most common pattern? I would've guessed that manually set options in an initializer should override the environment because they're explicitly set. Everything else makes perfect sense to me! |
Collaborator
Author
|
I think you're right @BrandonShar, that will be more Rails-y, will update the PR. |
80dc3e6 to
af63eab
Compare
af63eab to
747d621
Compare
Collaborator
|
Just to confirm, this one is ready to go yea? Last commit looks to resolve the conversation nicely! Would be nice to get this into the docs after we get it released! |
Collaborator
Author
|
Yup, it's ready 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR generalizes and improves upon the implementation from #172.
I would love to see a more general approach to control configuration values (e.g.,
ssr_enabled)Having the first point in mind, I needed to choose a strategy to prioritize gem defaults, global user configuration, env options, and finally controller-level configuration.
This is what I came up with, trying to follow the principle of least surprise:
InertiaRails.defaults → ENV → InertiaRails.configure → controller-level config
Example:
With this configuration, SSR will be enabled for
PublicControllerbut disabled forDashboardController.