Allow to set Inertia SSR URL via the ENV variable#172
Closed
brodienguyen wants to merge 1 commit intoinertiajs:masterfrom
Closed
Allow to set Inertia SSR URL via the ENV variable#172brodienguyen wants to merge 1 commit intoinertiajs:masterfrom
brodienguyen wants to merge 1 commit intoinertiajs:masterfrom
Conversation
BrandonShar
approved these changes
Feb 5, 2025
Collaborator
BrandonShar
left a comment
BrandonShar
left a comment
There was a problem hiding this comment.
This makes sense to me! The only mild pushback I'd have is that couldn't we already do this with an initializer? The convenience here is nice though.
Contributor
Author
|
Closing in the favor of: |
brodienguyen
deleted the
allow-to-set-Inertia-SSR-URL-from-the-env-variable
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to set
ssr_urldynamically using an ENV variable (INERTIA_SSR_URL) with a fallback value. This change is based on recent discussions about improving flexibility in configuring the Inertia SSR URL at: