Allow seeding for read-only files - #373
Open
Joaqim wants to merge 2 commits into
Open
Conversation
…t which stores boolean whether file is writeable or not
* New FileHandle struct: { file: File, is_writeable: bool }
* Replace `OpenedFile::file: RwLock<Option<File>>` with `::file_handle RwLock<Option<FileHandle>>`
Owner
|
Hey thanks for working on this. On a quick look from phone, I don't see anything that will make the file read only after it completed downloading. You mentioned it works as expected though, am I missing something? |
ikatson
added a commit
that referenced
this pull request
Jun 10, 2025
iPLAYCAFE-dev
pushed a commit
to iPLAYCAFE/rqbit
that referenced
this pull request
Aug 25, 2026
When init() fails to open a file in read/write mode due to PermissionDenied (common with antivirus, game launchers, backup tools), fall back to opening in read-only mode. This is sufficient for seeding completed files. Only applies to the allow_overwrite path where the file already exists. The create_new path (first download) still fails on permission errors, as write access is required. Addresses: ikatson#136, ikatson#509 Related community PRs: ikatson#489, ikatson#373
iPLAYCAFE-dev
pushed a commit
to iPLAYCAFE/rqbit
that referenced
this pull request
Aug 25, 2026
When opening a file in read/write mode fails with PermissionDenied or Windows ERROR_SHARING_VIOLATION (code 32), retry in read-only mode. This allows seeding of completed files that have been set to read-only by the user or are locked by another process (antivirus, backup tools). Completed files only need read access for seeding if writing is actually needed later, the write will fail gracefully at the OS level. The fallback only applies in allow_overwrite mode (existing files). Includes unit tests for: - Normal read/write open path - Read-only fallback behavior (unix) - pread_exact after read-only fallback (unix) - pwrite fails gracefully on read-only file (cross-platform) Related: ikatson#136, ikatson#509 See also: ikatson#489, ikatson#373 (alternative approaches)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a re implementation of a previous un-merged commit: d980e29 for issue #136
Full disclosure; while these changes are working for me so far with version 8.0.0, I'm a complete novice at working with Rust.
Most of these changes where assisted by use of an LLM, and I'm completely fine with some one taking over and doing a complete re-write as I'm not sure I followed best practices for my implementation.
If anyone does take this on, I would recommend starting from a05fd8b as it mostly contains previous changes by @ikatson from branch: seed-read-only