support seeding completed read-only files - #489
Draft
milahu wants to merge 2 commits into
Draft
Conversation
milahu
force-pushed
the
seed-read-only-2
branch
from
September 28, 2025 11:25
96c9d36 to
988d227
Compare
Author
for some torrents, i also get these errors |
milahu
force-pushed
the
seed-read-only-2
branch
from
October 26, 2025 18:00
988d227 to
b1a3074
Compare
iPLAYCAFE-dev
pushed a commit
to iPLAYCAFE/rqbit
that referenced
this pull request
Aug 25, 2026
When init() fails to open a file in read/write mode due to PermissionDenied (common with antivirus, game launchers, backup tools), fall back to opening in read-only mode. This is sufficient for seeding completed files. Only applies to the allow_overwrite path where the file already exists. The create_new path (first download) still fails on permission errors, as write access is required. Addresses: ikatson#136, ikatson#509 Related community PRs: ikatson#489, ikatson#373
iPLAYCAFE-dev
pushed a commit
to iPLAYCAFE/rqbit
that referenced
this pull request
Aug 25, 2026
When opening a file in read/write mode fails with PermissionDenied or Windows ERROR_SHARING_VIOLATION (code 32), retry in read-only mode. This allows seeding of completed files that have been set to read-only by the user or are locked by another process (antivirus, backup tools). Completed files only need read access for seeding if writing is actually needed later, the write will fail gracefully at the OS level. The fallback only applies in allow_overwrite mode (existing files). Includes unit tests for: - Normal read/write open path - Read-only fallback behavior (unix) - pread_exact after read-only fallback (unix) - pwrite fails gracefully on read-only file (cross-platform) Related: ikatson#136, ikatson#509 See also: ikatson#489, ikatson#373 (alternative approaches)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #136
based on d980e29
alternative to #373
packaged in nur.repos.milahu.rqbit
building rqbit with rust 1.87 fails with
this seems to work, but im getting these warnings