Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1272,7 +1272,6 @@ const buildContext = (
isMemsearchEnabled: true,
isMemoryComponentEnabled: true,
isClawEnabled: false,
clawConfigExists: false,
isScreenshareEnabled: false,
isVoiceCallEnabled: true,
isPrivacyEnabled: false,
Expand Down Expand Up @@ -1524,7 +1523,6 @@ describe('NavBar - Menu Filtering Logic (filterMentorSegments)', () => {
isMemsearchEnabled: false,
isMemoryComponentEnabled: true,
isClawEnabled: false,
clawConfigExists: false,
isScreenshareEnabled: false,
isVoiceCallEnabled: true,
isPrivacyEnabled: false,
Expand All @@ -1547,7 +1545,6 @@ describe('NavBar - Menu Filtering Logic (filterMentorSegments)', () => {
isMemsearchEnabled: true,
isMemoryComponentEnabled: true,
isClawEnabled: false,
clawConfigExists: false,
isScreenshareEnabled: false,
isVoiceCallEnabled: true,
isPrivacyEnabled: false,
Expand All @@ -1570,7 +1567,6 @@ describe('NavBar - Menu Filtering Logic (filterMentorSegments)', () => {
isMemsearchEnabled: true,
isMemoryComponentEnabled: true,
isClawEnabled: false,
clawConfigExists: false,
isScreenshareEnabled: false,
isVoiceCallEnabled: true,
isPrivacyEnabled: false,
Expand All @@ -1589,7 +1585,6 @@ describe('NavBar - Menu Filtering Logic (filterMentorSegments)', () => {
isMemsearchEnabled: false,
isMemoryComponentEnabled: true,
isClawEnabled: false,
clawConfigExists: false,
isScreenshareEnabled: false,
isVoiceCallEnabled: true,
isPrivacyEnabled: false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,9 @@ vi.mock('../tabs', () => ({
ScreenShareTab: () => (
<div data-testid="screenshare-tab">Screen Share Tab</div>
),
HumanSupportTab: () => (
<div data-testid="human-support-tab">Human Support Tab</div>
),
LtiTab: () => <div data-testid="lti-tab">LTI Tab</div>,
AnalyticsTab: () => <div data-testid="analytics-tab">Analytics Tab</div>,
}));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,9 @@ vi.mock('./tabs', () => ({
ScreenShareTab: () => (
<div data-testid="screenshare-tab">Screen Share Tab</div>
),
HumanSupportTab: () => (
<div data-testid="human-support-tab">Human Support Tab</div>
),
LtiTab: () => <div data-testid="lti-tab">LTI Tab</div>,
AnalyticsTab: () => <div data-testid="analytics-tab">Analytics Tab</div>,
}));
Expand Down
2 changes: 2 additions & 0 deletions components/modals/edit-mentor-modal/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import {
AuditLogTab,
VoiceTab,
ScreenShareTab,
HumanSupportTab,
LtiTab,
AnalyticsTab,
} from './tabs';
Expand Down Expand Up @@ -78,6 +79,7 @@ export const EDIT_MENTOR_TAB_COMPONENTS: Record<string, ReactNode> = {
[MODALS.EDIT_MENTOR.tabs.mcp]: <McpTab />,
[MODALS.EDIT_MENTOR.tabs.memory]: <MemoryTab />,
[MODALS.EDIT_MENTOR.tabs.history]: <HistoryTab />,
[MODALS.EDIT_MENTOR.tabs.human_support]: <HumanSupportTab />,
[MODALS.EDIT_MENTOR.tabs.audit_log]: <AuditLogTab />,
[MODALS.EDIT_MENTOR.tabs.datasets]: <DatasetsTab />,
[MODALS.EDIT_MENTOR.tabs.evaluation]: <EvaluationTab />,
Expand Down
198 changes: 198 additions & 0 deletions components/modals/edit-mentor-modal/tabs/human-support-tab.test.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,198 @@
import React from 'react';
import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
import { render, screen, cleanup } from '@testing-library/react';

import { HumanSupportTab } from './human-support-tab';

// ============================================================================
// MOCKS
// ============================================================================

const mockUseParams = vi.fn();
const mockGetMentorId = vi.fn();
const mockUseUsername = vi.fn();
const mockEnableRBAC = vi.fn();
const mockAgentSettingsProvider = vi.fn();
const mockAgentHumanSupportTab = vi.fn();

vi.mock('next/navigation', () => ({
useParams: () => mockUseParams(),
}));

vi.mock('@/hooks/user-navigate', () => ({
useNavigate: () => ({
getMentorId: mockGetMentorId,
}),
}));

vi.mock('@/hooks/use-user', () => ({
useUsername: () => mockUseUsername(),
}));

vi.mock('@/lib/config', () => ({
config: {
enableRBAC: () => mockEnableRBAC(),
},
}));

// HumanSupportTab imports from `@iblai/iblai-js/web-containers/next` (the
// Next-only entry — that's where AgentHumanSupportTab / AgentSettingsProvider
// are actually exported). Vitest keys mocks by module specifier, so we mock
// the exact path the source uses.
vi.mock('@iblai/iblai-js/web-containers/next', () => ({
AgentSettingsProvider: ({
children,
...value
}: {
children: React.ReactNode;
tenantKey: string;
mentorId: string;
username: string;
enableRBAC: boolean;
}) => {
mockAgentSettingsProvider(value);
return (
<div
data-testid="agent-settings-provider"
data-tenant-key={value.tenantKey}
data-mentor-id={value.mentorId}
data-username={value.username}
data-enable-rbac={String(value.enableRBAC)}
>
{children}
</div>
);
},
AgentHumanSupportTab: (props: unknown) => {
mockAgentHumanSupportTab(props);
return (
<div data-testid="agent-human-support-tab">AgentHumanSupportTab</div>
);
},
}));

// ============================================================================
// TESTS
// ============================================================================

describe('HumanSupportTab', () => {
beforeEach(() => {
cleanup();
vi.clearAllMocks();

mockUseParams.mockReturnValue({
tenantKey: 'test-tenant',
mentorId: 'test-mentor',
});
mockGetMentorId.mockReturnValue(null);
mockUseUsername.mockReturnValue('test-user');
mockEnableRBAC.mockReturnValue(false);
});

afterEach(() => {
cleanup();
});

describe('Rendering', () => {
it('wraps AgentHumanSupportTab in an AgentSettingsProvider with the resolved identity', () => {
render(<HumanSupportTab />);

const provider = screen.getByTestId('agent-settings-provider');
expect(provider).toHaveAttribute('data-tenant-key', 'test-tenant');
expect(provider).toHaveAttribute('data-mentor-id', 'test-mentor');
expect(provider).toHaveAttribute('data-username', 'test-user');
expect(provider).toHaveAttribute('data-enable-rbac', 'false');

expect(screen.getByTestId('agent-human-support-tab')).toBeInTheDocument();
expect(mockAgentSettingsProvider).toHaveBeenCalledWith({
tenantKey: 'test-tenant',
mentorId: 'test-mentor',
username: 'test-user',
enableRBAC: false,
});
});

it('does not pass a labels override so the SDK i18n catalog stays authoritative', () => {
render(<HumanSupportTab />);

expect(mockAgentHumanSupportTab).toHaveBeenCalledWith(
expect.not.objectContaining({ labels: expect.anything() }),
);
});

it('forwards the config-derived enableRBAC flag to the provider', () => {
mockEnableRBAC.mockReturnValue(true);

render(<HumanSupportTab />);

expect(screen.getByTestId('agent-settings-provider')).toHaveAttribute(
'data-enable-rbac',
'true',
);
expect(mockAgentSettingsProvider).toHaveBeenCalledWith(
expect.objectContaining({ enableRBAC: true }),
);
});
});

describe('Active mentor id resolution', () => {
it('prefers getMentorId() from navigate hook when provided', () => {
mockGetMentorId.mockReturnValue('nav-mentor-xyz');

render(<HumanSupportTab />);

expect(mockAgentSettingsProvider).toHaveBeenCalledWith(
expect.objectContaining({ mentorId: 'nav-mentor-xyz' }),
);
});

it('falls back to params.mentorId when getMentorId() returns null', () => {
mockGetMentorId.mockReturnValue(null);

render(<HumanSupportTab />);

expect(mockAgentSettingsProvider).toHaveBeenCalledWith(
expect.objectContaining({ mentorId: 'test-mentor' }),
);
});
});

describe('Guard clauses', () => {
it('renders nothing when tenantKey is missing', () => {
mockUseParams.mockReturnValue({
tenantKey: undefined,
mentorId: 'test-mentor',
});

const { container } = render(<HumanSupportTab />);

expect(container.firstChild).toBeNull();
expect(mockAgentSettingsProvider).not.toHaveBeenCalled();
expect(mockAgentHumanSupportTab).not.toHaveBeenCalled();
});

it('renders nothing when both mentorId and getMentorId() are missing', () => {
mockUseParams.mockReturnValue({
tenantKey: 'test-tenant',
mentorId: undefined,
});
mockGetMentorId.mockReturnValue(null);

const { container } = render(<HumanSupportTab />);

expect(container.firstChild).toBeNull();
expect(mockAgentSettingsProvider).not.toHaveBeenCalled();
expect(mockAgentHumanSupportTab).not.toHaveBeenCalled();
});

it('renders nothing when username is missing', () => {
mockUseUsername.mockReturnValue(undefined);

const { container } = render(<HumanSupportTab />);

expect(container.firstChild).toBeNull();
expect(mockAgentSettingsProvider).not.toHaveBeenCalled();
expect(mockAgentHumanSupportTab).not.toHaveBeenCalled();
});
});
});
37 changes: 37 additions & 0 deletions components/modals/edit-mentor-modal/tabs/human-support-tab.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
'use client';

import { useParams } from 'next/navigation';
import {
AgentHumanSupportTab,
AgentSettingsProvider,
} from '@iblai/iblai-js/web-containers/next';

import { useNavigate } from '@/hooks/user-navigate';
import { useUsername } from '@/hooks/use-user';
import { config } from '@/lib/config';
import { TenantKeyMentorIdParams } from '@/lib/types';

export function HumanSupportTab() {
const { tenantKey, mentorId } = useParams<TenantKeyMentorIdParams>();
const { getMentorId } = useNavigate();
const username = useUsername();
const activeMentorId = getMentorId() ?? mentorId;

if (!tenantKey || !activeMentorId || !username) return null;

// AgentHumanSupportTab reads tenant/mentor/username from the nearest
// AgentSettingsProvider (like AgentTasksTab), so the provider is required
// here. No `labels` override is passed — the SDK resolves every string
// through its own i18n catalog, which follows the app locale via the
// WebContainersI18nProvider bridge, so all copy stays translated.
return (
<AgentSettingsProvider
tenantKey={tenantKey}
mentorId={activeMentorId}
username={username}
enableRBAC={config.enableRBAC()}
>
<AgentHumanSupportTab />
</AgentSettingsProvider>
);
}
1 change: 1 addition & 0 deletions components/modals/edit-mentor-modal/tabs/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,6 @@ export * from './skills-tab';
export * from './audit-log-tab';
export * from './voice-tab';
export * from './screenshare-tab';
export * from './human-support-tab';
export * from './lti-tab';
export * from './analytics-tab';
Loading
Loading