Skip to content

Feat/2081 - #367

Merged
razasaddiqi merged 9 commits into
mainfrom
feat/2081
Jul 31, 2026
Merged

Feat/2081#367
razasaddiqi merged 9 commits into
mainfrom
feat/2081

Conversation

@razasaddiqi

@razasaddiqi razasaddiqi commented Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Checklist

  • Tests were added/updated according to the feature/bugfix/change made
  • Version was rolled according to semver requirements
  • API endpoints openapi schema was updated if applicable

Changes

  • Adds new agent tab for Support
  • Unit and playwright test for support tab as well
3 4 5 6

@razasaddiqi
razasaddiqi requested a review from mamigot as a code owner July 24, 2026 22:27
@mamigot

mamigot commented Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Claude finished @razasaddiqi's task —— View job

E2E Coverage Review

  • Dismiss stale REQUEST_CHANGES reviews — none found
  • Check changed files — no new page.tsx routes added
  • Run mechanical coverage check — passed (586 → 594 checkpoints, +8)
  • Read coverage files — correctly updated by developer
  • Apply decision logic — approved (CASE C: spec + coverage files both present and correct)

Result: ✅ Approved — Journey 65 (Mentor Human Support Tab) adds 8 new covered checkpoints. Coverage files are accurate.

mamigot
mamigot approved these changes Jul 24, 2026
View reviewed changes

@mamigot mamigot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ E2E Coverage — All Good

New component feature is covered and coverage files are up to date.

Coverage check result: 586 → 594 checkpoints (+8) ✅

New journey added:

  • Journey 65: Mentor Human Support Tab (65-mentor-human-support-tab.spec.ts)
  • 8 checkpoints, all marked covered

Coverage files verified:

  • e2e/coverage.json — new journey entry with correct sourceFiles and checkpoints
  • e2e/COVERAGE.md — matching [x] checkpoint lines added

@razasaddiqi razasaddiqi added the run-tests Trigger PR validation pipeline label Jul 24, 2026
@mamigot

mamigot commented Jul 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Claude finished @razasaddiqi's task —— View job

E2E Coverage Review

  • Dismiss stale REQUEST_CHANGES reviews — none found
  • Check changed files — no new page.tsx routes added
  • Run mechanical coverage check — passed (586 → 594 checkpoints, +8)
  • Read coverage files — correctly updated by developer
  • Apply decision logic — approved (CASE E: no new routes, coverage intact)

Result: ✅ Approved — No new app routes introduced. Journey 65 (Mentor Human Support Tab) adds 8 new covered checkpoints. Coverage files are accurate.

View job

mamigot
mamigot approved these changes Jul 27, 2026
View reviewed changes

@mamigot mamigot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ E2E Coverage — All Good

No new app routes were introduced. All existing coverage is intact.

Coverage check result: 586 → 594 checkpoints (+8) ✅

New journey added:

  • Journey 65: Mentor Human Support Tab (65-mentor-human-support-tab.spec.ts)
  • 8 checkpoints, all marked covered

Coverage files verified:

  • e2e/coverage.json — new journey entry with correct sourceFiles and checkpoints
  • e2e/COVERAGE.md — matching [x] checkpoint lines added

@razasaddiqi @claude
Merge branch 'main' of github.com:iblai/mentorai into feat/2081
11ffd2e 
Resolved conflicts in e2e/COVERAGE.md, e2e/coverage.json, package.json,
and pnpm-lock.yaml.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR E2E - OK

Full report, traces and screenshots
result OK
suite mentor - mode full - env stg1
tested against prod release 1.119.0 (env already on it)
failed 0
new failures 0

@bnsoni bnsoni added run-tests Trigger PR validation pipeline and removed run-tests Trigger PR validation pipeline labels Jul 30, 2026
bnsoni added a commit that referenced this pull request Jul 30, 2026
@bnsoni
fix(ci): make the e2e queue survive three concurrent PRs
4f27b31 
GitHub keeps only ONE pending run per concurrency group. A third dispatch
CANCELS the previously-pending one before it starts a single job — silently,
with no diagnosis on the PR.

os#390 was dropped exactly this way: #394 took the group, #390 queued, #367
arrived and evicted #390. Its check went red having tested nothing.

This was masked while stg2 shared the load across two groups; pinning
everything to stg1 made a three-deep queue routine.

Two changes, and both are needed:

  Wait for a free dispatch slot before firing. The caller polls until no
  run for this env is queued/pending, so the pending slot is never
  contested. Costs nothing new — the caller already polls for up to 2h;
  this just moves the wait earlier, and prints 'N run(s) queued ahead'
  instead of failing silently.

  Retry on eviction. Two callers can still check simultaneously and both
  dispatch. A central run that ends 'cancelled' having started ZERO jobs is
  an eviction, not a result — re-dispatch (up to 3 attempts) rather than
  reddening the PR.

Neither alone suffices: the wait has a residual race, and retry alone would
let PRs thrash.

Dispatch and wait merge into one step so the retry can span both. The gate
now reads steps.dispatch.outputs.conclusion. The liveness guard
(busy-vs-offline) and phase streaming are carried over unchanged.
bnsoni and others added 2 commits July 31, 2026 00:33
@bnsoni
ci: adopt the current PR-e2e caller on this branch
f216d97 
Only .github/workflows/pr-e2e-tests.yml, copied from main. No other code
from main is pulled in.

A pull_request workflow runs from the MERGE commit, and this branch is 20
commits behind — so it would still run the caller as it was this morning:
no wait-for-slot (would risk evicting a queued PR), and a 2h timeout that
counts QUEUE time, which is exactly why this PR's last run reported no
report link while its result was fine.

Brings: ECR registry, wait-for-slot + stagger, eviction retry, orphan
cancel, busy-vs-offline liveness guard, execution-only timeout, and the
result-artifact download retry.
@bnsoni @claude
Merge main into feat/2081 — pick up the pr-e2e eviction-retry + orpha…
0b987ff 
…n-cleanup fix (#399)

The only conflict was .github/workflows/pr-e2e-tests.yml, where this branch
carried a pre-fix copy of the CI caller. Resolved to main's version wholesale:
the caller workflow is shared infrastructure, not part of this feature.

Refreshing the merge ref is what makes the re-run actually use the fixed step —
pull_request runs execute the workflow from the merge commit, so open PRs keep
running the old one until main is merged in.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@razasaddiqi
razasaddiqi requested a review from conradmugabe July 31, 2026 18:33
@razasaddiqi
razasaddiqi merged commit 036cf0a into main Jul 31, 2026
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mamigot mamigot mamigot approved these changes
@conradmugabe conradmugabe conradmugabe approved these changes

Assignees

No one assigned

Labels

run-tests Trigger PR validation pipeline

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@razasaddiqi @mamigot @conradmugabe @bnsoni