Skip to content

fix: use version 0 for IndexingAgreementVersion.V1 in metadata validation #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MoonBoi9001 wants to merge 1 commit into
base: feat/dips-rejection-logging
Choose a base branch
from
Open

fix: use version 0 for IndexingAgreementVersion.V1 in metadata validation #983

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions crates/dips/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,8 +420,8 @@ pub async fn validate_and_create_rca(
))
})?;

// Only support version 1 terms for now
if metadata.version != 1 {
// Only support V1 terms (IndexingAgreementVersion.V1 = 0 in Solidity enum)
if metadata.version != 0 {
return Err(DipsError::UnsupportedMetadataVersion(metadata.version));
}

Expand Down Expand Up @@ -569,7 +569,7 @@ mod test {
let metadata = AcceptIndexingAgreementMetadata {
// Any bytes32 works - MockIpfsFetcher ignores the deployment ID
subgraphDeploymentId: FixedBytes::ZERO,
version: 1,
version: 0, // IndexingAgreementVersion.V1 = 0
terms: terms.abi_encode().into(),
};

Expand Down Expand Up @@ -824,7 +824,7 @@ mod test {

let metadata = AcceptIndexingAgreementMetadata {
subgraphDeploymentId: FixedBytes::ZERO,
version: 1,
version: 0, // IndexingAgreementVersion.V1 = 0
terms: terms.abi_encode().into(),
};

Expand Down Expand Up @@ -868,7 +868,7 @@ mod test {

let metadata = AcceptIndexingAgreementMetadata {
subgraphDeploymentId: FixedBytes::ZERO,
version: 1,
version: 0, // IndexingAgreementVersion.V1 = 0
terms: terms.abi_encode().into(),
};

Expand Down
Loading