fix: use version 0 for IndexingAgreementVersion.V1 in metadata validation#983
Open
MoonBoi9001 wants to merge 1 commit intofeat/dips-rejection-loggingfrom
Open
fix: use version 0 for IndexingAgreementVersion.V1 in metadata validation#983MoonBoi9001 wants to merge 1 commit intofeat/dips-rejection-loggingfrom
MoonBoi9001 wants to merge 1 commit intofeat/dips-rejection-loggingfrom
Conversation
…tion The Solidity enum IndexingAgreementVersion has V1 as its first variant, which encodes as 0 in the ABI. The validation check was comparing against 1, causing all valid V1 proposals to be rejected with UnsupportedMetadataVersion. Test data also updated to use version 0. Companion to edgeandnode/dipper#583. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
During local DIPs end-to-end testing, valid V1 proposals were being rejected by the indexer-service with
UnsupportedMetadataVersion(0). The version check was comparing against1when the Solidity enumIndexingAgreementVersion.V1actually encodes as0.Summary
The Solidity enum
IndexingAgreementVersionhasV1as its first variant, which encodes as0in the ABI. The validation was checkingmetadata.version != 1, which rejected all valid V1 proposals. Changed to!= 0. Test metadata also updated to use version0.Companion to edgeandnode/dipper#583.
Generated with Claude Code