Skip to content
Open
Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
b68d628
refactor: decouple ConsistencyRequest from TableAdminRequestContext
jinseopkim0 Apr 15, 2026
6e39723
chore: generate libraries at Wed Apr 15 18:37:03 UTC 2026
cloud-java-bot Apr 15, 2026
00db638
feat: introduce Bigtable Admin V2 clients for Selective GAPIC
jinseopkim0 Apr 15, 2026
ccdee5d
chore: generate libraries at Wed Apr 15 20:12:56 UTC 2026
cloud-java-bot Apr 15, 2026
d781aad
Merge branch 'refactor-consistency-request' into refactor-consistency…
jinseopkim0 Apr 15, 2026
bff60a6
PR feedback
jinseopkim0 Apr 17, 2026
d368825
chore: generate libraries at Fri Apr 17 14:55:58 UTC 2026
cloud-java-bot Apr 17, 2026
392717f
PR comment 2
jinseopkim0 Apr 17, 2026
ed4476a
chore: generate libraries at Fri Apr 17 16:31:54 UTC 2026
cloud-java-bot Apr 17, 2026
95f4d32
PR feedback 3
jinseopkim0 Apr 17, 2026
a817081
Merge branch 'main' into refactor-consistency-request-2
jinseopkim0 Apr 23, 2026
78dad41
restore files
jinseopkim0 Apr 23, 2026
7abd5cb
restore files
jinseopkim0 Apr 23, 2026
c6ff5c5
fix build
jinseopkim0 Apr 23, 2026
0341958
PR feedback
jinseopkim0 Apr 23, 2026
2fcffb5
chore: generate libraries at Thu Apr 23 16:12:59 UTC 2026
cloud-java-bot Apr 23, 2026
a83b8b6
PR feedback
jinseopkim0 Apr 24, 2026
1778913
lint
jinseopkim0 Apr 24, 2026
69bdb15
improve javadoc
jinseopkim0 Apr 24, 2026
d145048
improve exception message
jinseopkim0 Apr 24, 2026
8afa72f
PR feedback 1
jinseopkim0 Apr 27, 2026
12888ee
PR feedback 2
jinseopkim0 Apr 27, 2026
9a5a405
chore: generate libraries at Mon Apr 27 20:03:03 UTC 2026
cloud-java-bot Apr 27, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
/*
* Copyright 2026 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.google.cloud.bigtable.admin.v2;

import com.google.cloud.bigtable.admin.v2.stub.BigtableInstanceAdminStub;
import java.io.IOException;

/**
* Modern Cloud Bigtable Instance Admin Client.
*
* <p>This client extends the {@link BaseBigtableInstanceAdminClient} to provide a simplified and
* enhanced API surface for managing Cloud Bigtable instances and clusters.
*/
public class BigtableInstanceAdminClientV2 extends BaseBigtableInstanceAdminClient {

protected BigtableInstanceAdminClientV2(BaseBigtableInstanceAdminSettings settings)
throws IOException {
super(settings);
}

protected BigtableInstanceAdminClientV2(BigtableInstanceAdminStub stub) {
super(stub);
}

/** Constructs an instance of BigtableInstanceAdminClientV2 with the given settings. */
public static final BigtableInstanceAdminClientV2 create(
BaseBigtableInstanceAdminSettings settings) throws IOException {
return new BigtableInstanceAdminClientV2(settings);
}

/** Constructs an instance of BigtableInstanceAdminClientV2 with the given stub. */
public static final BigtableInstanceAdminClientV2 create(BigtableInstanceAdminStub stub) {
return new BigtableInstanceAdminClientV2(stub);
}
Comment thread
jinseopkim0 marked this conversation as resolved.
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,341 @@
/*
* Copyright 2026 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.google.cloud.bigtable.admin.v2;

import com.google.api.core.ApiFunction;
import com.google.api.core.ApiFuture;
import com.google.api.core.ApiFutures;
import com.google.api.gax.grpc.GrpcCallSettings;
import com.google.api.gax.grpc.GrpcCallableFactory;
import com.google.api.gax.grpc.ProtoOperationTransformers.MetadataTransformer;
import com.google.api.gax.grpc.ProtoOperationTransformers.ResponseTransformer;
import com.google.api.gax.longrunning.OperationSnapshot;
import com.google.api.gax.longrunning.OperationTimedPollAlgorithm;
import com.google.api.gax.retrying.RetrySettings;
import com.google.api.gax.rpc.ApiExceptions;
import com.google.api.gax.rpc.ClientContext;
import com.google.api.gax.rpc.OperationCallSettings;
import com.google.api.gax.rpc.OperationCallable;
import com.google.api.gax.rpc.UnaryCallSettings;
import com.google.api.gax.rpc.UnaryCallable;
import com.google.bigtable.admin.v2.OptimizeRestoredTableMetadata;
import com.google.cloud.bigtable.admin.v2.models.ConsistencyRequest;
import com.google.cloud.bigtable.admin.v2.models.OptimizeRestoredTableOperationToken;
import com.google.cloud.bigtable.admin.v2.models.RestoredTableResult;
import com.google.cloud.bigtable.admin.v2.stub.AwaitConsistencyCallable;
import com.google.cloud.bigtable.admin.v2.stub.BigtableTableAdminStub;
import com.google.cloud.bigtable.admin.v2.stub.BigtableTableAdminStubSettings;
import com.google.common.base.Strings;
import com.google.longrunning.Operation;
import com.google.protobuf.Empty;
import io.grpc.MethodDescriptor;
import io.grpc.MethodDescriptor.Marshaller;
import io.grpc.MethodDescriptor.MethodType;
import java.io.IOException;
import java.io.InputStream;
import java.time.Duration;
import java.util.concurrent.ExecutionException;

/**
* Modern Cloud Bigtable Table Admin Client.
*
* <p>This client extends the {@link BaseBigtableTableAdminClient} to provide enhanced convenience
* methods for table administration. It improves the user experience by handling chained Long
* Running Operations (such as seamlessly restoring and then optimizing a table) and provides
* built-in, automated polling for consistency tokens.
*/
public class BigtableTableAdminClientV2 extends BaseBigtableTableAdminClient {
private final AwaitConsistencyCallable awaitConsistencyCallable;
private final OperationCallable<Void, Empty, OptimizeRestoredTableMetadata>
optimizeRestoredTableOperationBaseCallable;

protected BigtableTableAdminClientV2(BaseBigtableTableAdminSettings settings) throws IOException {
super(settings);
this.awaitConsistencyCallable =
createAwaitConsistencyCallable((BigtableTableAdminStubSettings) settings.getStubSettings());
this.optimizeRestoredTableOperationBaseCallable =
createOptimizeRestoredTableOperationBaseCallable(
(BigtableTableAdminStubSettings) settings.getStubSettings());
}

protected BigtableTableAdminClientV2(BigtableTableAdminStub stub) {
super(stub);
this.awaitConsistencyCallable = null;
this.optimizeRestoredTableOperationBaseCallable = null;
}

@com.google.common.annotations.VisibleForTesting
BigtableTableAdminClientV2(
BigtableTableAdminStub stub,
AwaitConsistencyCallable awaitConsistencyCallable,
OperationCallable<Void, Empty, OptimizeRestoredTableMetadata>
optimizeRestoredTableOperationBaseCallable) {
super(stub);
this.awaitConsistencyCallable = awaitConsistencyCallable;
this.optimizeRestoredTableOperationBaseCallable = optimizeRestoredTableOperationBaseCallable;
}

private AwaitConsistencyCallable createAwaitConsistencyCallable(
BigtableTableAdminStubSettings settings) throws IOException {
ClientContext clientContext = ClientContext.create(settings);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not great, ClientContexts are pretty heavy (they create a new grpc channel). I think the only reason you need from the context is the clock & executor. I think you'll be better off creating those for this child class and not trying getting access to the ClientContext

// TODO(igorbernstein2): expose polling settings
RetrySettings pollingSettings =
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets extract this to a constant

RetrySettings.newBuilder()
.setTotalTimeout(
settings.checkConsistencySettings().getRetrySettings().getTotalTimeout())
.setInitialRetryDelayDuration(Duration.ofSeconds(10))
.setRetryDelayMultiplier(1.0)
.setMaxRetryDelayDuration(Duration.ofSeconds(10))
.setInitialRpcTimeoutDuration(Duration.ZERO)
.setMaxRpcTimeoutDuration(Duration.ZERO)
.setRpcTimeoutMultiplier(1.0)
.build();

return AwaitConsistencyCallable.create(
getStub().generateConsistencyTokenCallable(),
getStub().checkConsistencyCallable(),
clientContext,
pollingSettings);
}

private OperationCallable<Void, Empty, OptimizeRestoredTableMetadata>
createOptimizeRestoredTableOperationBaseCallable(BigtableTableAdminStubSettings settings)
throws IOException {
ClientContext clientContext = ClientContext.create(settings);

GrpcCallSettings<Void, Operation> unusedInitialCallSettings =
GrpcCallSettings.create(
MethodDescriptor.<Void, Operation>newBuilder()
.setType(MethodType.UNARY)
.setFullMethodName(
"google.bigtable.admin.v2.BigtableTableAdmin/OptimizeRestoredTable")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would be better to declare a dep on the grpc stubs and pull this from the MethodDescriptor?

.setRequestMarshaller(
new Marshaller<Void>() {
@Override
public InputStream stream(Void value) {
throw new UnsupportedOperationException("not used");
}

@Override
public Void parse(InputStream stream) {
throw new UnsupportedOperationException("not used");
}
})
.setResponseMarshaller(
new Marshaller<Operation>() {
@Override
public InputStream stream(Operation value) {
throw new UnsupportedOperationException("not used");
}

@Override
public Operation parse(InputStream stream) {
throw new UnsupportedOperationException("not used");
}
})
.build());

final MetadataTransformer<OptimizeRestoredTableMetadata> protoMetadataTransformer =
MetadataTransformer.create(OptimizeRestoredTableMetadata.class);

final ResponseTransformer<com.google.protobuf.Empty> protoResponseTransformer =
ResponseTransformer.create(com.google.protobuf.Empty.class);

OperationCallSettings<Void, Empty, OptimizeRestoredTableMetadata> operationCallSettings =
OperationCallSettings.<Void, Empty, OptimizeRestoredTableMetadata>newBuilder()
.setInitialCallSettings(
UnaryCallSettings.<Void, OperationSnapshot>newUnaryCallSettingsBuilder()
.setSimpleTimeoutNoRetriesDuration(Duration.ZERO)
.build())
.setMetadataTransformer(
new ApiFunction<OperationSnapshot, OptimizeRestoredTableMetadata>() {
@Override
public OptimizeRestoredTableMetadata apply(OperationSnapshot input) {
return protoMetadataTransformer.apply(input);
}
})
.setResponseTransformer(
new ApiFunction<OperationSnapshot, Empty>() {
@Override
public Empty apply(OperationSnapshot input) {
return protoResponseTransformer.apply(input);
}
})
.setPollingAlgorithm(
OperationTimedPollAlgorithm.create(
RetrySettings.newBuilder()
.setInitialRetryDelayDuration(Duration.ofMillis(500L))
.setRetryDelayMultiplier(1.5)
.setMaxRetryDelayDuration(Duration.ofMillis(5000L))
.setInitialRpcTimeoutDuration(Duration.ZERO)
.setRpcTimeoutMultiplier(1.0)
.setMaxRpcTimeoutDuration(Duration.ZERO)
.setTotalTimeoutDuration(Duration.ofMillis(600000L))
.build()))
.build();

return GrpcCallableFactory.createOperationCallable(
unusedInitialCallSettings,
operationCallSettings,
clientContext,
getStub().getOperationsStub());
}

/** Constructs an instance of BigtableTableAdminClientV2 with the given settings. */
public static final BigtableTableAdminClientV2 create(BaseBigtableTableAdminSettings settings)
throws IOException {
return new BigtableTableAdminClientV2(settings);
}

/** Constructs an instance of BigtableTableAdminClientV2 with the given stub. */
public static final BigtableTableAdminClientV2 create(BigtableTableAdminStub stub) {
return new BigtableTableAdminClientV2(stub);
}

/**
* Awaits the completion of the "Optimize Restored Table" operation.
*
* <p>This method blocks until the restore operation is complete, extracts the optimization token,
* and returns an ApiFuture for the optimization phase.
*
* @param restoreFuture The future returned by restoreTableAsync().
* @return An ApiFuture that tracks the optimization progress.
*/
public ApiFuture<Empty> awaitOptimizeRestoredTable(ApiFuture<RestoredTableResult> restoreFuture) {
// 1. Block and wait for the restore operation to complete
RestoredTableResult result;
try {
result = restoreFuture.get();
} catch (Exception e) {
throw new RuntimeException("Restore operation failed", e);
}

// 2. Extract the operation token from the result
// (RestoredTableResult already wraps the OptimizeRestoredTableOperationToken)
OptimizeRestoredTableOperationToken token = result.getOptimizeRestoredTableOperationToken();

if (token == null || Strings.isNullOrEmpty(token.getOperationName())) {
// If there is no optimization operation, return immediate success.
return ApiFutures.immediateFuture(Empty.getDefaultInstance());
}

// 3. Return the future for the optimization operation
return getOptimizeRestoredTableCallable().resumeFutureCall(token.getOperationName());
}

/**
* Awaits a restored table is fully optimized.
*
* <p>Sample code
*
* <pre>{@code
* RestoredTableResult result =
* client.restoreTable(RestoreTableRequest.of(clusterId, backupId).setTableId(tableId));
* client.awaitOptimizeRestoredTable(result.getOptimizeRestoredTableOperationToken());
* }</pre>
*/
public void awaitOptimizeRestoredTable(OptimizeRestoredTableOperationToken token)
throws ExecutionException, InterruptedException {
awaitOptimizeRestoredTableAsync(token).get();
}

/**
* Awaits a restored table is fully optimized asynchronously.
*
* <p>Sample code
*
* <pre>{@code
* RestoredTableResult result =
* client.restoreTable(RestoreTableRequest.of(clusterId, backupId).setTableId(tableId));
* ApiFuture<Void> future = client.awaitOptimizeRestoredTableAsync(
* result.getOptimizeRestoredTableOperationToken());
*
* ApiFutures.addCallback(
* future,
* new ApiFutureCallback<Void>() {
* public void onSuccess(Void unused) {
* System.out.println("The optimization of the restored table is done.");
* }
*
* public void onFailure(Throwable t) {
* t.printStackTrace();
* }
* },
* MoreExecutors.directExecutor()
* );
* }</pre>
*/
public ApiFuture<Void> awaitOptimizeRestoredTableAsync(
OptimizeRestoredTableOperationToken token) {
ApiFuture<Empty> emptyFuture =
getOptimizeRestoredTableCallable().resumeFutureCall(token.getOperationName());
return ApiFutures.transform(
emptyFuture,
new com.google.api.core.ApiFunction<Empty, Void>() {
@Override
public Void apply(Empty input) {
return null;
}
},
com.google.common.util.concurrent.MoreExecutors.directExecutor());
}

/**
* Polls an existing consistency token until table replication is consistent across all clusters.
* Useful for checking consistency of a token generated in a separate process. Blocks until
* completion.
*
* @param tableName The fully qualified table name to check.
* @param consistencyToken The token to poll.
*/
public void waitForConsistency(String tableName, String consistencyToken) {
ApiExceptions.callAndTranslateApiException(
waitForConsistencyAsync(tableName, consistencyToken));
}

/**
* Asynchronously polls the consistency token. Returns a future that completes when table
* replication is consistent across all clusters.
*
* @param tableName The fully qualified table name to check.
* @param consistencyToken The token to poll.
*/
public ApiFuture<Void> waitForConsistencyAsync(String tableName, String consistencyToken) {
return getAwaitConsistencyCallable()
.futureCall(ConsistencyRequest.forReplicationFromTableName(tableName, consistencyToken));
}

private UnaryCallable<ConsistencyRequest, Void> getAwaitConsistencyCallable() {
if (awaitConsistencyCallable != null) {
return awaitConsistencyCallable;
}
throw new IllegalStateException(
"AwaitConsistencyCallable not initialized. BigtableTableAdminClientV2 must be "
+ "initialized via BigtableTableAdminClientV2.create(BaseBigtableTableAdminSettings) "
+ "to use this functionality.");
}

private OperationCallable<Void, Empty, OptimizeRestoredTableMetadata>
getOptimizeRestoredTableCallable() {
if (optimizeRestoredTableOperationBaseCallable != null) {
return optimizeRestoredTableOperationBaseCallable;
}
throw new IllegalStateException(
"OptimizeRestoredTableCallable not initialized. BigtableTableAdminClientV2 must be "
+ "initialized via BigtableTableAdminClientV2.create(BaseBigtableTableAdminSettings) "
+ "to use this functionality.");
}
}
Loading
Loading