feat: introduce Bigtable Admin V2 clients for Selective GAPIC#2889
Open
jinseopkim0 wants to merge 20 commits intomainfrom
Open
feat: introduce Bigtable Admin V2 clients for Selective GAPIC#2889jinseopkim0 wants to merge 20 commits intomainfrom
jinseopkim0 wants to merge 20 commits intomainfrom
Conversation
This commit updates the internal plumbing for `ConsistencyRequest` and `AwaitConsistencyCallable` to support fully qualified table names without breaking the existing public API for the legacy `BigtableTableAdminClient`. b/502616786
product-auto-label
Bot
added
size: l
jinseopkim0
force-pushed
the
refactor-consistency-request-2
branch
2 times, most recently
from
979d668 to
eabb07a
Compare
This commit adds `BigtableTableAdminClientV2` and `BigtableInstanceAdminClientV2`, which extend the autogenerated base clients. These classes serve as the new, independent entry points for the Selective GAPIC hierarchy. For `BigtableTableAdminClientV2`, the manual wrappers for Critical User Journeys (CUJs) like `awaitOptimizeRestoredTable` and `waitForConsistency` have been relocated from the legacy client. It utilizes the new context-free ConsistencyRequest factories introduced in the previous refactoring step. For `BigtableInstanceAdminClientV2`, the class acts as a standardized entry point, as no manual overrides were required from the legacy client. b/502616786
jinseopkim0
force-pushed
the
refactor-consistency-request-2
branch
from
849de6d to
00db638
Compare
igorbernstein2
requested changes
Apr 16, 2026
jinseopkim0
added
the
kokoro:force-run
jinseopkim0
added
the
kokoro:run
yoshi-kokoro
removed
kokoro:run
jinseopkim0
added
kokoro:force-run
yoshi-kokoro
removed
kokoro:run
lqiu96
reviewed
Apr 24, 2026
lqiu96
reviewed
Apr 24, 2026
igorbernstein2
requested changes
Apr 27, 2026
|
|
||
| private AwaitConsistencyCallable createAwaitConsistencyCallable( | ||
| BigtableTableAdminStubSettings settings) throws IOException { | ||
| ClientContext clientContext = ClientContext.create(settings); |
Contributor
There was a problem hiding this comment.
This is not great, ClientContexts are pretty heavy (they create a new grpc channel). I think the only reason you need from the context is the clock & executor. I think you'll be better off creating those for this child class and not trying getting access to the ClientContext
| BigtableTableAdminStubSettings settings) throws IOException { | ||
| ClientContext clientContext = ClientContext.create(settings); | ||
| // TODO(igorbernstein2): expose polling settings | ||
| RetrySettings pollingSettings = |
Contributor
There was a problem hiding this comment.
Lets extract this to a constant
| MethodDescriptor.<Void, Operation>newBuilder() | ||
| .setType(MethodType.UNARY) | ||
| .setFullMethodName( | ||
| "google.bigtable.admin.v2.BigtableTableAdmin/OptimizeRestoredTable") |
Contributor
There was a problem hiding this comment.
I wonder if it would be better to declare a dep on the grpc stubs and pull this from the MethodDescriptor?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds
BigtableTableAdminClientV2andBigtableInstanceAdminClientV2, which extend the autogenerated base clients. These classes serve as the new, independent entry points for the Selective GAPIC hierarchy.For
BigtableTableAdminClientV2, the manual wrappers for Critical User Journeys (CUJs) likeawaitOptimizeRestoredTableandwaitForConsistencyhave been relocated from the legacy client. It utilizes the new context-free ConsistencyRequest factories introduced in the previous refactoring step.For
BigtableInstanceAdminClientV2, the class acts as a standardized entry point, as no manual overrides were required from the legacy client.b/502616786