Initial RFC-3 support - #156
Conversation
glencoesoftware/bioformats2raw@29867c6 is expected to fix the ordering issue, so this PR just needs some tests. |
|
Tests added in 506a0fe depend upon the current state of glencoesoftware/bioformats2raw#330. I tested this locally by checking out the Proposed next steps:
|
This is for a better test of the modulo + compact case, since the C axis will be compacted (but the lifetime axis remains).
|
Tests should now cover the case in glencoesoftware/bioformats2raw#330 (comment), and are passing locally. The build failure is still expected as this is dependent upon the current state of glencoesoftware/bioformats2raw#330 being installed locally. |
|
I applied the latest changes of this PR to the set of OME-Zarr samples generated as per glencoesoftware/bioformats2raw#330 (comment). I encountered similar failures for the ICS and OIR samples I suspect we need to decide on how to resolve glencoesoftware/bioformats2raw#330 (comment) in order to unblock this |
… are `ModuloAlong*`
|
With 648f08c and the current state of glencoesoftware/bioformats2raw#330, I was able to successfully convert the .ics data without error (I haven't tried the .oir one yet). I was initially very concerned that data was being converted incorrectly when looking at the output OME-TIFF (since large areas are blank in many planes), but comparing the original .ics and converted OME-TIFF plane-by-plane in ImageJ confirmed that this is expected. |
Companion to glencoesoftware/bioformats2raw#330.
Draft for now, as this still needs tests. I kind of suspect there is a dimension ordering issue (in particular with FLIM-ModuloAlongC.ome.tiff), but needs more investigation to determine which PR needs work (if either).