Skip to content

build(deps): Pin pdb2 patch to a commit #2145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elramen merged 1 commit into from
Nov 4, 2026
Merged

build(deps): Pin pdb2 patch to a commit #2145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3223,7 +3223,7 @@ dependencies = [
[[package]]
name = "pdb2"
version = "0.10.2"
source = "git+https://github.com/getsentry/pdb2?branch=master#47b1880d8046f4bdb7c84f4b6c3a673fcf642601"
source = "git+https://github.com/getsentry/pdb2?rev=47b1880d8046f4bdb7c84f4b6c3a673fcf642601#47b1880d8046f4bdb7c84f4b6c3a673fcf642601"
dependencies = [
"fallible-iterator",
"scroll 0.12.0",
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ reqwest = { git = "https://github.com/getsentry/reqwest", branch = "swatinem/upd
cpp_demangle = { git = "https://github.com/getsentry/cpp_demangle", branch = "sentry-patches-0.5" }

# This patch returns a parse error instead of panicking on `LF_VFTABLE` records with a malformed name list length (SYMBOLICATOR-65)
pdb2 = { git = "https://github.com/getsentry/pdb2", branch = "master" }
pdb2 = { git = "https://github.com/getsentry/pdb2", rev = "47b1880d8046f4bdb7c84f4b6c3a673fcf642601" }

@Dav1dde Dav1dde Nov 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit is now released in 0.11.0, would be good to contribute a change to pdb-addr2line to bump the dependency so we can actually get rid of the patch.

@elramen elramen Nov 4, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mstange/pdb-addr2line#75


# All the swc-related crates to patch to get our memory bounding in.
swc_ecma_visit = { git = "https://github.com/getsentry/swc", rev = "2a26d98fce614a20c7cc9b5373b61355b70ffa1d" }
Expand Down
Loading