Repository navigation
build(deps): Pin pdb2 patch to a commit - #2145
Merged
Merged
Conversation
Reference the getsentry/pdb2 fork by commit instead of the master branch, so updating the lockfile cannot pull in unreviewed changes.
elramen
marked this pull request as ready for review
November 3, 2026 15:58
Dav1dde
approved these changes
Nov 3, 2026
|
|
||
| # This patch returns a parse error instead of panicking on `LF_VFTABLE` records with a malformed name list length (SYMBOLICATOR-65) | ||
| pdb2 = { git = "https://github.com/getsentry/pdb2", branch = "master" } | ||
| pdb2 = { git = "https://github.com/getsentry/pdb2", rev = "47b1880d8046f4bdb7c84f4b6c3a673fcf642601" } |
Member
There was a problem hiding this comment.
This commit is now released in 0.11.0, would be good to contribute a change to pdb-addr2line to bump the dependency so we can actually get rid of the patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depend on specific commit instead of branch.