Repository navigation
feat(sourcemaps): Set has_debug_ids when assembling an artifact bundle - #130422
Open
sentry-junior[bot] wants to merge 2 commits into
Open
sentry-junior[bot] wants to merge 2 commits into
sentry-junior[bot] wants to merge 2 commits into
Conversation
A new bundle gets the flag from whether its archive has files with debug IDs, which is also when its DebugIdArtifactBundle rows are written. A re-upload of an existing bundle writes no debug-ID rows, so it leaves the flag as it is. Co-Authored-By: Jan Michael Auer <1433023+jan-auer@users.noreply.github.com>
github-actions
Bot
added
the
Scope: Backend
lcian
approved these changes
Nov 9, 2026
…tifact-bundle-write-has-debug-ids Co-Authored-By: Jan Michael Auer <1433023+jan-auer@users.noreply.github.com>
mchen-sentry
added
the
Trigger: getsentry tests
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArtifactBundle.has_debug_idstells whether a bundle has debug-ID rows, so the source map debugger does not need to read those rows.The upload sets the flag when it creates a new bundle. This is the same step that writes the debug-ID rows. A new upload of an existing bundle writes no debug-ID rows, so it does not change the flag either.
via @jan-auer.
--
View Session [Sentry]