Repository navigation
feat(sourcemaps): Backfill has_debug_ids on artifact bundles - #130424
Open
sentry-junior[bot] wants to merge 4 commits into
Open
sentry-junior[bot] wants to merge 4 commits into
sentry-junior[bot] wants to merge 4 commits into
Conversation
Sets the flag on every bundle that has DebugIdArtifactBundle rows. Bundles uploaded since the write path deployed already have it, so this has to run after that change is deployed. Co-Authored-By: Jan Michael Auer <1433023+jan-auer@users.noreply.github.com>
github-actions
Bot
added
the
Scope: Backend
Contributor
|
This PR has a migration; here is the generated SQL for for --
-- Add field has_debug_ids to artifactbundle
--
ALTER TABLE "sentry_artifactbundle" ADD COLUMN "has_debug_ids" boolean DEFAULT false NOT NULL;for --
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL |
lcian
reviewed
Nov 9, 2026
The backfill prints its own progress lines, so it does not need the progress bar wrapper.
lcian
reviewed
Nov 9, 2026
lcian
approved these changes
Nov 9, 2026
Without the has_debug_ids filter, the range scan over bundles reads only the primary key index. The update still skips bundles that are already flagged.
…kfill-artifact-bundle-has-debug-ids Co-Authored-By: Jan Michael Auer <1433023+jan-auer@users.noreply.github.com>
mchen-sentry
added
the
Trigger: getsentry tests
wedamija
approved these changes
Nov 9, 2026
wedamija
left a comment
wedamija
left a comment
Member
There was a problem hiding this comment.
This table has around 100m rows. It'll probably take a while to process this, but I think it should be able to run successfully.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundles uploaded before #130422 have
has_debug_ids = false, even when they have debug-ID rows. This post-deployment migration sets the flag on these bundles.The migration reads the bundles in batches of 1,000. For each bundle, it checks for one debug-ID row through the
artifact_bundle_idindex. It only sets the flag totrue, so it is safe to run again.Requires #130422
via @jan-auer.
--
View Session [Sentry]