Install types.xsd for all spec versions - #1704
Open
scpeters wants to merge 1 commit into
Open
Conversation
Also add a dependency for the generated xsd files on the xmlschema.py script. Assisted-by: Gemini 3.6 Flash Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Part of #1656
Summary
Gemini noticed that the
types.xsdschema files that are present in each sdf spec folder (such as sdf/1.12/schema/types.xsd) are not installed alongside the other.sdfand.xsdfiles. This installs all of those files.Gemini also noticed that the
.xsdfiles generated by the xmlschema.py script do not have a dependency declared on that script. This adds that dependency to ensure that all.xsdfiles will be regenerated when the xmlschema.py script is modified.Backport Policy
There will be conflicts when backporting to collections without SDFormat 1.12
Checklist
codecheckpassed (See contributing)Assisted-by: Gemini 3.6 Flash
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.Backports: If this is a backport, please use Rebase and Merge instead.