Skip to content

Install types.xsd for all spec versions - #1704

Open
scpeters wants to merge 1 commit into
mainfrom
scpeters/install_types_xsd
Open

Install types.xsd for all spec versions#1704
scpeters wants to merge 1 commit into
mainfrom
scpeters/install_types_xsd

Conversation

@scpeters

@scpeters scpeters commented Sep 1, 2026

Copy link
Copy Markdown
Member

🦟 Bug fix

Part of #1656

Summary

Gemini noticed that the types.xsd schema files that are present in each sdf spec folder (such as sdf/1.12/schema/types.xsd) are not installed alongside the other .sdf and .xsd files. This installs all of those files.

Gemini also noticed that the .xsd files generated by the xmlschema.py script do not have a dependency declared on that script. This adds that dependency to ensure that all .xsd files will be regenerated when the xmlschema.py script is modified.

Backport Policy

  • This is safe to backport to the following versions:
    • Jetty
    • Ionic
    • Harmonic
    • Fortress
  • This should not be backported
  • I am not sure
  • Other (fill in yourself)

There will be conflicts when backporting to collections without SDFormat 1.12

Checklist

  • Signed all commits for DCO
  • Added a screen capture or video to the PR description that demonstrates the fix (as needed)
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • Updated Bazel files (if adding new files). Created an issue otherwise.
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Assisted-by" to your commits. (See this policy for more info.)

Assisted-by: Gemini 3.6 Flash

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Backports: If this is a backport, please use Rebase and Merge instead.

Also add a dependency for the generated xsd files
on the xmlschema.py script.

Assisted-by: Gemini 3.6 Flash

Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

2 participants