Update chewbbaca with manual species ID#7870
Update chewbbaca with manual species ID#7870nilchia wants to merge 4 commits intogalaxyproject:mainfrom
Conversation
| @@ -20,9 +20,7 @@ | |||
| <option value="species">species</option> | |||
| <option value="schemas">schemas</option> | |||
| </param> | |||
There was a problem hiding this comment.
I assume this should become a conditional for the next two parameters?
| <xml name="species_id" token_optional="false" token_value="1"> | ||
| <param argument="--species-id" type="integer" min="1" value="@VALUE@" optional="@OPTIONAL@" label="Schema ID" help="To see avaialble species and their IDs, please run chewBBACA NSStats with Mode = species"/> |
There was a problem hiding this comment.
Seems like the correct thing to do, yes 👍
|
I think it is good to go |
|
Please report this upstream. A species identifier that does not identify seems wrong and super user unfriendly. Maybe suggest to use taxids? Do the IDs depend on used reference data? Does the user know how to find the correct IDs? |
|
Yes it is really user unfriendly. Yes users can run NSSTATS.xml tool to get list of available species in the database. Also other thing is that the tool is not reproducible if the IDs change. |
|
ping: @pavanvidem 480d9cb |
|
Did adding "unzip" cause that error? |
No, it is coming from plotly |
The species ID is not static and changes over time.
This update makes it users resposibility to check the correct species ID.
Fixes: #7868
I'll open another PR later and also update the tool version.
FOR CONTRIBUTOR:
There are two labels that allow to ignore specific (false positive) tool linter errors:
skip-version-check: Use it if only a subset of the tools has been updated in a suite.skip-url-check: Use it if github CI sees 403 errors, but the URLs work.