Skip to content

Update chewbbaca with manual species ID#7870

Open
nilchia wants to merge 4 commits intogalaxyproject:mainfrom
nilchia:update_chewbbaca
Open

Update chewbbaca with manual species ID#7870
nilchia wants to merge 4 commits intogalaxyproject:mainfrom
nilchia:update_chewbbaca

Conversation

@nilchia
Copy link
Copy Markdown
Collaborator

@nilchia nilchia commented Apr 9, 2026

The species ID is not static and changes over time.

This update makes it users resposibility to check the correct species ID.

Fixes: #7868

I'll open another PR later and also update the tool version.

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

There are two labels that allow to ignore specific (false positive) tool linter errors:

  • skip-version-check: Use it if only a subset of the tools has been updated in a suite.
  • skip-url-check: Use it if github CI sees 403 errors, but the URLs work.

Comment thread tools/chewbbaca/NSStats.xml Outdated
@@ -20,9 +20,7 @@
<option value="species">species</option>
<option value="schemas">schemas</option>
</param>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this should become a conditional for the next two parameters?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. added here e6b3f94

Comment thread tools/chewbbaca/macros.xml Outdated
Comment on lines +19 to +20
<xml name="species_id" token_optional="false" token_value="1">
<param argument="--species-id" type="integer" min="1" value="@VALUE@" optional="@OPTIONAL@" label="Schema ID" help="To see avaialble species and their IDs, please run chewBBACA NSStats with Mode = species"/>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the correct thing to do, yes 👍

@nilchia nilchia marked this pull request as ready for review April 9, 2026 13:07
@nilchia nilchia requested a review from wm75 April 10, 2026 13:46
@nilchia
Copy link
Copy Markdown
Collaborator Author

nilchia commented Apr 10, 2026

I think it is good to go

@bernt-matthias
Copy link
Copy Markdown
Contributor

Please report this upstream. A species identifier that does not identify seems wrong and super user unfriendly. Maybe suggest to use taxids?

Do the IDs depend on used reference data? Does the user know how to find the correct IDs?

@nilchia
Copy link
Copy Markdown
Collaborator Author

nilchia commented Apr 10, 2026

Yes it is really user unfriendly.

Yes users can run NSSTATS.xml tool to get list of available species in the database.

Also other thing is that the tool is not reproducible if the IDs change.

@nilchia
Copy link
Copy Markdown
Collaborator Author

nilchia commented Apr 13, 2026

ping: @pavanvidem 480d9cb

@nilchia
Copy link
Copy Markdown
Collaborator Author

nilchia commented Apr 13, 2026

Did adding "unzip" cause that error?

@pavanvidem
Copy link
Copy Markdown
Member

Did adding "unzip" cause that error?

No, it is coming from plotly

Job in error state.. tool_id: chewbbaca_extractcgmlst, exit_code: 1, stderr: Traceback (most recent call last):
  File "/usr/local/bin/chewBBACA.py", line 10, in <module>
    sys.exit(main())
             ^^^^^^
  File "/usr/local/lib/python3.11/site-packages/CHEWBBACA/chewBBACA.py", line 1543, in main
    functions_info[process][1]()
  File "/usr/local/lib/python3.11/site-packages/CHEWBBACA/utils/process_datetime.py", line 146, in wrapper
    func(*args, **kwargs)
  File "/usr/local/lib/python3.11/site-packages/CHEWBBACA/chewBBACA.py", line 810, in run_determine_cgmlst
    determine_cgmlst.main(**vars(args))
  File "/usr/local/lib/python3.11/site-packages/CHEWBBACA/ExtractCgMLST/determine_cgmlst.py", line 365, in main
    fig.update_xaxes(range=[0, len(sorted_genomes)],
  File "/usr/local/lib/python3.11/site-packages/plotly/graph_objs/_figure.py", line 23508, in update_xaxes
    obj.update(patch, overwrite=overwrite, **kwargs)
  File "/usr/local/lib/python3.11/site-packages/plotly/basedatatypes.py", line 5195, in update
    BaseFigure._perform_update(self, kwargs, overwrite=overwrite)
  File "/usr/local/lib/python3.11/site-packages/plotly/basedatatypes.py", line 3949, in _perform_update
    raise err
ValueError: Invalid property specified for object of type plotly.graph_objs.layout.XAxis: 'titlefont'

Did you mean "tickfont"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chewbbaca DownloadSchema: Wrong species IDs assumed in wrapper

4 participants