Skip to content

Add MAGmax#7869

Open
SantaMcCloud wants to merge 7 commits intogalaxyproject:mainfrom
SantaMcCloud:add_magmax
Open

Add MAGmax#7869
SantaMcCloud wants to merge 7 commits intogalaxyproject:mainfrom
SantaMcCloud:add_magmax

Conversation

@SantaMcCloud
Copy link
Copy Markdown
Contributor

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

There are two labels that allow to ignore specific (false positive) tool linter errors:

  • skip-version-check: Use it if only a subset of the tools has been updated in a suite.
  • skip-url-check: Use it if github CI sees 403 errors, but the URLs work.

Comment thread tools/magmax/magmax.xml
</command>
<inputs>
<param name="bindir" type="data" format="fasta" multiple="true" label="Input bin file(s)"/>
<param name="readdir" type="data_collection" optional="true" collection_type="list:paired" format="fastq" multiple="true" label="Input read files"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<param name="readdir" type="data_collection" optional="true" collection_type="list:paired" format="fastq" multiple="true" label="Input read files"
<param name="readdir" type="data_collection" optional="true" collection_type="list:paired" format="fastqsanger" multiple="true" label="Input read files"

Is fastqsanger.gz supported?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didnt found any in the readme but i will ask and upate it if this is supported!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i did ask about it and *.gz files are not yet supported. It can be that in a month it will be supported but this depends if they release it with the next version. But it is planed to be added!

Comment thread tools/magmax/magmax.xml
<inputs>
<param name="bindir" type="data" format="fasta" multiple="true" label="Input bin file(s)"/>
<param name="readdir" type="data_collection" optional="true" collection_type="list:paired" format="fastq" multiple="true" label="Input read files"
help="The identifier of the pair should be name after the [sample_id] otherwise the tool can not work. For more information check the help section at the bottom of the tool! NOTE: when using the {--no-reassembly} or {--sensitive} mode this input is not needed!"/>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shoudn't this param only be available if --no-reassembly or --sensitive is not used?

Copy link
Copy Markdown
Contributor Author

@SantaMcCloud SantaMcCloud Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes corret this parameter and mapiddir should be available if neither one of them is used. Of one of the them or both are used then only bindir param is needed as input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants