[23.2] Yaml nested assertions: fix parsing#17641
[23.2] Yaml nested assertions: fix parsing#17641mvdbeek merged 5 commits intogalaxyproject:release_23.2from
Conversation
were forgotten to be implemented
57aeecf to
73ced4e
Compare
73ced4e to
df7c2af
Compare
| """ | ||
| - has_archive_member: | ||
| path: ".*" | ||
| children: |
There was a problem hiding this comment.
I guess that's what your comment about asserts was about ? It does feel more consistent for that to be
asserts:
- has_text:
text: thing
?
There was a problem hiding this comment.
I used the syntax from the other examples in the file
I'm still struggling with yaml, but it seems that
yaml.load("""
asserts:
- has_text:
text: thing
"""
)
gives `{'asserts': [{'has_text': None, 'text': 'thing'}]}`
while
```python
yaml.load("""
asserts:
- has_text:
text: thing
"""
)gives {'asserts': [{'has_text': {'text': 'thing'}}]}. Not sure if both versions are parsed at the moment.
Not sure if the former even works.
There was a problem hiding this comment.
Sorry, typing without checking, it should be
asserts:
- has_text:
text: thing
There was a problem hiding this comment.
Yes this is what I meant with my comment at the planemo issue
Not sure, but easy to implement I guess. But I can clearly live with the current state. The only question would be if it would simplify anything if we use asserts?
There was a problem hiding this comment.
Yes, then we can re-use models and there's no question what you have to use IMO - it's always asserts.
There was a problem hiding this comment.
Then remove children completely, or leave it as falll back? I guess since it seems that this was never used, we may just change it?
There was a problem hiding this comment.
Leave it as a fallback but don't document it would be my suggestion ?
|
This PR was merged without a "kind/" label, please correct. |
Seems that the recursive call was forgotten.
How to test the changes?
(Select all options that apply)
License