-
Notifications
You must be signed in to change notification settings - Fork 803
[V2] Replace minio with rustfs #7180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
popojk
wants to merge
9
commits into
v2
Choose a base branch
from
switch_from_minio_to_rustfs
base: v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
fb0c662
switch from minio to rustfs
popojk 892b3f3
Merge remote-tracking branch 'origin/v2' into switch_from_minio_to_ru…
popojk cd079f8
re build
popojk b1f91b3
rebase
popojk 83b826e
let it rain
popojk 16b29f0
remove rustfs console
popojk ec3cff8
minor fix
popojk 10089cc
rebase
popojk bc5e56f
fix reviews
popojk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pingsutw marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -53,35 +53,3 @@ spec: | |
| number: 80 | ||
| {{- end }} | ||
| --- | ||
| {{- if .Values.minio.enabled }} | ||
| apiVersion: networking.k8s.io/v1 | ||
| kind: Ingress | ||
| metadata: | ||
| name: {{ include "flyte-demo.fullname" . }}-minio | ||
| namespace: {{ .Release.Namespace | quote }} | ||
| labels: {{- include "flyte-demo.labels" . | nindent 4 }} | ||
| annotations: | ||
| traefik.ingress.kubernetes.io/router.middlewares: {{ .Release.Namespace }}-strip-minio@kubernetescrd | ||
| spec: | ||
| rules: | ||
| - http: | ||
| paths: | ||
| - path: /minio | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't we need ingress for rustfs console? which url should we use now in chrome to open the UI? |
||
| pathType: Prefix | ||
| backend: | ||
| service: | ||
| name: minio | ||
| port: | ||
| number: 9001 | ||
| --- | ||
| apiVersion: traefik.io/v1alpha1 | ||
| kind: Middleware | ||
| metadata: | ||
| name: strip-minio | ||
| namespace: {{ .Release.Namespace | quote }} | ||
| labels: {{- include "flyte-demo.labels" . | nindent 4 }} | ||
| spec: | ||
| stripPrefix: | ||
| prefixes: | ||
| - /minio | ||
| {{- end }} | ||
85 changes: 85 additions & 0 deletions
85
charts/flyte-demo/templates/storage/rustfs/deployment.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| {{- if .Values.rustfs.enabled }} | ||
| apiVersion: apps/v1 | ||
| kind: Deployment | ||
| metadata: | ||
| name: {{ .Release.Name }}-rustfs | ||
| namespace: {{ .Release.Namespace | quote }} | ||
| labels: | ||
| {{- include "flyte-demo.labels" . | nindent 4 }} | ||
| spec: | ||
| selector: | ||
| matchLabels: | ||
| app.kubernetes.io/name: rustfs | ||
| app.kubernetes.io/instance: {{ .Release.Name }} | ||
| strategy: | ||
| type: Recreate | ||
| template: | ||
| metadata: | ||
| labels: | ||
| app.kubernetes.io/name: rustfs | ||
| app.kubernetes.io/instance: {{ .Release.Name }} | ||
| spec: | ||
| initContainers: | ||
| - name: volume-permissions | ||
| image: busybox:latest | ||
| imagePullPolicy: IfNotPresent | ||
| command: | ||
| - /bin/sh | ||
| - -ec | ||
| - | | ||
| chown -R 10001:10001 /data | ||
| mkdir -p /data/flyte-data | ||
| chown 10001:10001 /data/flyte-data | ||
| securityContext: | ||
| runAsUser: 0 | ||
| volumeMounts: | ||
| - mountPath: /data | ||
| name: data | ||
| containers: | ||
| - name: rustfs | ||
| image: rustfs/rustfs:latest | ||
| imagePullPolicy: IfNotPresent | ||
| env: | ||
| - name: RUSTFS_ADDRESS | ||
| value: "0.0.0.0:9000" | ||
| - name: RUSTFS_VOLUMES | ||
| value: "/data" | ||
| - name: RUSTFS_ACCESS_KEY | ||
| valueFrom: | ||
| secretKeyRef: | ||
| name: {{ .Release.Name }}-rustfs | ||
| key: access-key | ||
| - name: RUSTFS_SECRET_KEY | ||
| valueFrom: | ||
| secretKeyRef: | ||
| name: {{ .Release.Name }}-rustfs | ||
| key: secret-key | ||
| ports: | ||
| - containerPort: 9000 | ||
| name: rustfs-api | ||
| protocol: TCP | ||
| livenessProbe: | ||
| tcpSocket: | ||
| port: rustfs-api | ||
| initialDelaySeconds: 10 | ||
| periodSeconds: 10 | ||
| failureThreshold: 5 | ||
| readinessProbe: | ||
| tcpSocket: | ||
| port: rustfs-api | ||
| initialDelaySeconds: 5 | ||
| periodSeconds: 5 | ||
| failureThreshold: 5 | ||
| securityContext: | ||
| runAsUser: 10001 | ||
| runAsNonRoot: true | ||
| volumeMounts: | ||
| - mountPath: /data | ||
| name: data | ||
| securityContext: | ||
| fsGroup: 10001 | ||
| volumes: | ||
| - name: data | ||
| persistentVolumeClaim: | ||
| claimName: {{ include "flyte-sandbox.persistence.rustfsVolumeName" . }} | ||
| {{- end }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| {{- if .Values.rustfs.enabled }} | ||
| apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| name: {{ .Release.Name }}-rustfs | ||
| namespace: {{ .Release.Namespace | quote }} | ||
| labels: | ||
| {{- include "flyte-demo.labels" . | nindent 4 }} | ||
| type: Opaque | ||
| data: | ||
| access-key: {{ .Values.rustfs.accessKey | b64enc | quote }} | ||
| secret-key: {{ .Values.rustfs.secretKey | b64enc | quote }} | ||
| {{- end }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| {{- if .Values.rustfs.enabled }} | ||
| apiVersion: v1 | ||
| kind: Service | ||
| metadata: | ||
| name: {{ .Release.Name }}-rustfs | ||
| namespace: {{ .Release.Namespace | quote }} | ||
| labels: | ||
| {{- include "flyte-demo.labels" . | nindent 4 }} | ||
| spec: | ||
| type: NodePort | ||
| ports: | ||
| - name: rustfs-api | ||
| nodePort: 30002 | ||
| port: 9000 | ||
| targetPort: rustfs-api | ||
| selector: | ||
| app.kubernetes.io/name: rustfs | ||
| app.kubernetes.io/instance: {{ .Release.Name }} | ||
| {{- end }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| apiVersion: apps/v1 | ||
| kind: Deployment | ||
| metadata: | ||
| name: flyte-demo-rustfs | ||
| namespace: flyte | ||
| spec: | ||
| template: | ||
| spec: | ||
| initContainers: | ||
| - name: volume-permissions | ||
| command: | ||
| - /bin/sh | ||
| - -ec | ||
| - | | ||
| chown -R 10001:10001 /data | ||
| mkdir -p /data/flyte-data | ||
| chown 10001:10001 /data/flyte-data | ||
pingsutw marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| containers: | ||
| - name: rustfs | ||
| env: | ||
| - name: RUSTFS_ADDRESS | ||
| value: "0.0.0.0:9000" | ||
| - name: RUSTFS_VOLUMES | ||
| value: "/data" | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.