Conversation
Signed-off-by: Alex Wu <c.alexwu@gmail.com>
…stfs Signed-off-by: Alex Wu <c.alexwu@gmail.com>
Signed-off-by: Alex Wu <c.alexwu@gmail.com>
Signed-off-by: Alex Wu <c.alexwu@gmail.com>
| - | | ||
| chown -R 10001:10001 /data | ||
| mkdir -p /data/flyte-data | ||
| chown 10001:10001 /data/flyte-data |
There was a problem hiding this comment.
It looks like that rustfs do not have a config to set default bucket, so I used a init container to create it
There was a problem hiding this comment.
do we still need patch? i see you already add it here
https://github.com/flyteorg/flyte/pull/7180/files#diff-32a785edcaf63ee58f8bf71c4c2964596bcb0058680cb2cfb69b33d804ec5af4R27-R33
manager/config.yaml
Outdated
| k8s: | ||
| default-env-vars: | ||
| - FLYTE_AWS_ENDPOINT: "http://minio.flyte.svc.cluster.local:9000" | ||
| - FLYTE_AWS_ENDPOINT: "http://flyte-demo-rustfs.flyte.svc.cluster.local:9000" |
There was a problem hiding this comment.
Could we override the pod/service name to rustfs instead of flyte-demo-rustfs
| */}} | ||
| {{- define "flyte-demo.persistence.minioVolumeName" -}} | ||
| {{- printf "%s-minio-storage" .Release.Name -}} | ||
| {{- define "flyte-sandbox.persistence.rustfsVolumeName" -}} |
| - | | ||
| chown -R 10001:10001 /data | ||
| mkdir -p /data/flyte-data | ||
| chown 10001:10001 /data/flyte-data |
There was a problem hiding this comment.
do we still need patch? i see you already add it here
https://github.com/flyteorg/flyte/pull/7180/files#diff-32a785edcaf63ee58f8bf71c4c2964596bcb0058680cb2cfb69b33d804ec5af4R27-R33
| kind: PersistentVolumeClaim | ||
| metadata: | ||
| name: {{ include "flyte-demo.persistence.minioVolumeName" . }} | ||
| name: {{ include "flyte-sandbox.persistence.rustfsVolumeName" . }} |
| image: busybox:latest | ||
| imagePullPolicy: IfNotPresent |
There was a problem hiding this comment.
Could we create an image tar file and put it into the flyte-sandbox-2 image at build time instead? so sandbox won't pull the image from remote at runtime.
| kind: PersistentVolume | ||
| metadata: | ||
| name: {{ include "flyte-demo.persistence.minioVolumeName" . }} | ||
| name: {{ include "flyte-sandbox.persistence.rustfsVolumeName" . }} |
There was a problem hiding this comment.
Could we remove this empty file?
Signed-off-by: Alex Wu <c.alexwu@gmail.com>
3 participants
Tracking issue
Closes #7179
Why are the changes needed?
Replace minio with rustfs for better performance
P.S. We will do rustfs console in seperate PR
What changes were proposed in this pull request?
Mainly delete minio and add rustfs in heml chart
How was this patch tested?
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
main