test: improve coverage for apphosting yaml configs#10355
Open
Conversation
### Description Implement loading, merging, storing assertions and fix environment map formatting bugs for app hosting setup. ### Scenarios Tested - Loading basic strings and merging overlapping targets
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the unit tests for AppHostingYamlConfig, introducing Sinon stubs for file system and utility modules to improve test isolation. It also fixes a bug in the toEnvMap utility where the original environment object was being mutated instead of its clone. Feedback was provided to improve type safety by replacing an 'any' cast with 'Partial' in accordance with the repository style guide.
| const variable = env.variable; | ||
| const tmp = { ...env }; | ||
| delete (env as any).variable; | ||
| delete (tmp as any).variable; |
Contributor
There was a problem hiding this comment.
The use of any as an escape hatch is discouraged by the repository style guide (Line 38). You can avoid it by casting to Partial<Env>, which allows the deletion of the required variable property while maintaining better type safety than any.
Suggested change
| delete (tmp as any).variable; | |
| delete (tmp as Partial<Env>).variable; |
References
- Never use any or unknown as an escape hatch. Define proper interfaces/types or use type guards. (link)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement loading, merging, storing assertions and fix environment map formatting bugs for app hosting setup.
Scenarios Tested