Reduce macro usage in PDMA#2247
Closed
Dominaezzz wants to merge 1 commit into
Closed
Conversation
Contributor
|
Not sure why you closed this, I'm pretty sure the change is worth it, unless you have a better idea. |
6 tasks
Collaborator
Author
|
I remembered what you said in #2196 (comment) and decided to close it, and replace it with #2249 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
Pull out as much code as possible from the PDMA macros.
My IDE has a better time with code outside macros. If no one else's IDE is bothered by this I'll close the PR.
I've actually gotten the code to the point where I can probably merge the
ImplI2sChannelandImplSpiChannelmacros into one macro with a few more parameters.No changelog since this is an internal refactor.
Testing
It builds, it's just a refactor.