Skip to content

clean up release tooling #3177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
turadg merged 6 commits into from
Apr 14, 2026
Merged

clean up release tooling #3177

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
62215a4
chore(deps): rm obsolete Lerna patches
turadg Apr 13, 2026
c730052
chore(deps): rm obsolete conventional-changelog-conventionalcommits
turadg Apr 13, 2026
0e489a3
chore(deps): minor bump Lerna
turadg Apr 13, 2026
40b2ec7
chore(deps): bump @changesets/changelog-github
turadg Apr 13, 2026
9740c1b
chore(deps): bump @changesets/cli
turadg Apr 13, 2026
15fa040
build: rm obsolete lerna versioning
turadg Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions .yarn/patches/@lerna-conventional-commits-npm-5.6.2-a373ba4bc0.patch
View file
Open in desktop

This file was deleted.

33 changes: 0 additions & 33 deletions .yarn/patches/@lerna-version-npm-5.6.2-ce2d9cb2f5.patch
View file
Open in desktop

This file was deleted.

13 changes: 3 additions & 10 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
},
"packageManager": "yarn@4.13.0",
"devDependencies": {
"@changesets/changelog-github": "^0.5.2",
"@changesets/cli": "^2.29.8",
"@changesets/changelog-github": "^0.6.0",
"@changesets/cli": "^2.30.0",
"@endo/compartment-mapper": "workspace:^",
"@endo/eslint-plugin": "workspace:^",
"@endo/marshal": "workspace:^",
Expand All @@ -30,7 +30,7 @@
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-import": "^2.31.0",
"eslint-plugin-jsdoc": "^50.6.1",
"lerna": "^8.1.8",
"lerna": "^8.2.4",
"prettier": "^3.5.3",
"ses": "workspace:^",
"source-map": "^0.7.4",
Expand Down Expand Up @@ -63,20 +63,13 @@
"build": "yarn workspaces foreach --all run build",
"build-ts": "tsc --build tsconfig.build.json"
},
"dependencies": {
"conventional-changelog-conventionalcommits": "^4.6.0"
},
"prettier": {
Comment on lines 62 to 66
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conventional-changelog-conventionalcommits is removed here, but lerna.json still sets command.version.changelogPreset to "conventionalcommits". Lerna typically resolves that preset by requiring conventional-changelog-conventionalcommits, so lerna version/conventional-changelog generation may fail at runtime once this dep is gone. Either keep this package as a devDependency, or update lerna.json to use a preset that is actually available (e.g. one Lerna bundles) or remove the changelogPreset override.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member Author

@turadg turadg Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boneskull we version by Changesets now instead of Lerna, right? Maybe there's more to clean up in lerna.json.

Copy link
Copy Markdown
Member

@boneskull boneskull Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, we don't need that config for Lerna any longer. All that Lerna's doing is lerna publish from-package which determines which packages need publishing and routes them thru yarn publish.

Related: LavaMoat/LavaMoat#1888

This PR should get @lavamoat/laverna in shape so that it can fully replace lerna in Endo.

"arrowParens": "avoid",
"singleQuote": true
},
"typeCoverage": {
"atLeast": 0
},
"resolutions": {
"@lerna/version@npm:5.6.2": "patch:@lerna/version@npm%3A5.6.2#~/.yarn/patches/@lerna-version-npm-5.6.2-ce2d9cb2f5.patch",
"@lerna/conventional-commits@npm:5.6.2": "patch:@lerna/conventional-commits@npm%3A5.6.2#~/.yarn/patches/@lerna-conventional-commits-npm-5.6.2-a373ba4bc0.patch"
},
"eslintConfig": {
"root": true
},
Expand Down
Loading
Loading