Conversation
Linkify issue references in changelog entries https://github.com/changesets/changesets/releases/tag/%40changesets%2Fchangelog-github%400.6.0
|
There was a problem hiding this comment.
Pull request overview
This PR cleans up and modernizes the release tooling dependency set by updating Changesets/Lerna versions and removing legacy dependencies/patches that targeted older Lerna releases.
Changes:
- Bump
@changesets/cliand@changesets/changelog-githubto newer minor versions. - Bump
lernato^8.2.4and refresh the lockfile accordingly. - Remove obsolete
conventional-changelog-conventionalcommitsand Yarn patch files/resolutions that targeted Lerna5.6.2.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
package.json |
Updates dev dependency versions; removes conventional-changelog-conventionalcommits and old Yarn patch resolutions. |
yarn.lock |
Lockfile refresh for bumped Changesets/Lerna and removal of now-unused packages. |
.yarn/patches/@lerna-version-npm-5.6.2-ce2d9cb2f5.patch |
Deletes obsolete patch for Lerna 5.x. |
.yarn/patches/@lerna-conventional-commits-npm-5.6.2-a373ba4bc0.patch |
Deletes obsolete patch for Lerna 5.x. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "test262": "yarn workspaces foreach --all run test262", | ||
| "build": "yarn workspaces foreach --all run build", | ||
| "build-ts": "tsc --build tsconfig.build.json" | ||
| }, | ||
| "dependencies": { | ||
| "conventional-changelog-conventionalcommits": "^4.6.0" | ||
| }, | ||
| "prettier": { |
There was a problem hiding this comment.
conventional-changelog-conventionalcommits is removed here, but lerna.json still sets command.version.changelogPreset to "conventionalcommits". Lerna typically resolves that preset by requiring conventional-changelog-conventionalcommits, so lerna version/conventional-changelog generation may fail at runtime once this dep is gone. Either keep this package as a devDependency, or update lerna.json to use a preset that is actually available (e.g. one Lerna bundles) or remove the changelogPreset override.
There was a problem hiding this comment.
@boneskull we version by Changesets now instead of Lerna, right? Maybe there's more to clean up in lerna.json.
There was a problem hiding this comment.
Right, we don't need that config for Lerna any longer. All that Lerna's doing is lerna publish from-package which determines which packages need publishing and routes them thru yarn publish.
Related: LavaMoat/LavaMoat#1888
This PR should get @lavamoat/laverna in shape so that it can fully replace lerna in Endo.
boneskull
left a comment
boneskull
left a comment
There was a problem hiding this comment.
This is good, with the caveat that lerna.json may need pruning.
All that Lerna's doing now is `lerna publish from-package` which determines which packages need publishing and routes them thru `yarn publish`. �[1m$ �[22myarn run [--inspect] [--inspect-brk] [-T,--top-level] [-B,--binaries-only] [--require #0] <scriptName> ....
Description
Clean up release tooling dependencies:
@changesets/clifrom ^2.29.8 to ^2.30.0@changesets/changelog-githubfrom ^0.5.2 to ^0.6.0lernafrom ^8.1.8 to ^8.2.4conventional-changelog-conventionalcommitsdependency (was independenciesinstead ofdevDependenciesand is no longer used).yarn/patches/for@lerna/versionand@lerna/conventional-commits(patches targeted v5.6.2, current lerna is v8.x)Security Considerations
No new authorities or trust boundaries. Dependency bumps are minor/patch versions.
Scaling Considerations
No impact.
Documentation Considerations
None.
Testing Considerations
CI should verify that
yarn installresolves cleanly and existing release scripts still work.Compatibility Considerations
No breaking changes. The removed patches targeted Lerna 5.x which is no longer in use.
Upgrade Considerations
None.