-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Remove barrel file imports from internal code #21295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| export * from './lib/context'; | ||
| export * from './lib/env'; | ||
| export { context, getLookup, setLookup, type GlobalContext } from './lib/context'; | ||
| export { ENV, getENV } from './lib/env'; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| export { | ||
| Helper as default, | ||
| default as default, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can just be
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed — |
||
| helper, | ||
| type FunctionBasedHelper, | ||
| type FunctionBasedHelperInstance, | ||
| } from '@ember/-internals/glimmer'; | ||
| } from '@ember/-internals/glimmer/lib/helper'; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,11 +5,13 @@ | |
|
|
||
| export { setComponentTemplate, getComponentTemplate } from '@glimmer/manager'; | ||
|
|
||
| export { Component as default, Input, Textarea } from '@ember/-internals/glimmer'; | ||
| export { default as default } from '@ember/-internals/glimmer/lib/component'; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can just be export { default }, yea?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed — |
||
| export { default as Input } from '@ember/-internals/glimmer/lib/components/input'; | ||
| export { default as Textarea } from '@ember/-internals/glimmer/lib/components/textarea'; | ||
| export { | ||
| componentCapabilities as capabilities, | ||
| setComponentManager, | ||
| } from '@ember/-internals/glimmer'; | ||
| } from '@ember/-internals/glimmer/lib/utils/managers'; | ||
|
|
||
| /** | ||
| * Assigns a TemplateFactory to a component class. | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| export * from './lib/engine-parent'; | ||
| export { ENGINE_PARENT, getEngineParent, setEngineParent } from './lib/engine-parent'; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| export { LinkTo } from '@ember/-internals/glimmer'; | ||
| export { default as LinkTo } from '@ember/-internals/glimmer/lib/components/link-to'; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,6 @@ | ||
| export * from './lib/-internal/primitives'; | ||
| export { | ||
| RESOLUTION_MODE_TRANSFORMS, | ||
| STRICT_MODE_TRANSFORMS, | ||
| STRICT_MODE_KEYWORDS, | ||
| INTERNAL_PLUGINS, | ||
| } from './lib/-internal/primitives'; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,7 @@ | ||
| export * from './lib/plugins/utils'; | ||
| export { | ||
| isPath, | ||
| isSubExpression, | ||
| isStringLiteral, | ||
| inScope, | ||
| trackLocals, | ||
| } from './lib/plugins/utils'; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| export * from './lib/public-api'; | ||
| export { template } from './lib/public-api'; | ||
| export type { EmberPrecompileOptions } from './lib/public-api'; | ||
|
|
||
| export { ALLOWED_GLOBALS } from './lib/plugins/allowed-globals'; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| export * from './public-api'; | ||
| export { template } from './public-api'; | ||
| export type { EmberPrecompileOptions } from './public-api'; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| export * from './lib/runtime'; | ||
| export { template, type EmberPrecompileOptions } from './lib/runtime'; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,7 @@ | ||
| export * from '@ember/template-compiler/-internal-utils'; | ||
| export { | ||
| isPath, | ||
| isSubExpression, | ||
| isStringLiteral, | ||
| inScope, | ||
| trackLocals, | ||
| } from '@ember/template-compiler/-internal-utils'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this totally redundant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes —
...environmentwas spreading{ hasDOM, window, location, history, userAgent, isChrome, isFirefox }from@ember/-internals/browser-environment, but theBootEnvironmenttype only useshasDOM,isInteractive,_renderMode, andoptions. The explicithasDOM: this.isBrowserwas already overriding it. The other properties (window,location, etc.) were not in the type and not used by any consumer.