Remove barrel file imports from internal code#21295
Open
NullVoxPopuli-ai-agent wants to merge 1 commit intoemberjs:mainfrom
Open
Remove barrel file imports from internal code#21295NullVoxPopuli-ai-agent wants to merge 1 commit intoemberjs:mainfrom
NullVoxPopuli-ai-agent wants to merge 1 commit intoemberjs:mainfrom
Conversation
Replace all internal barrel imports (from `@ember/-internals/glimmer`,
`@ember/-internals/environment`, etc.) with direct imports from the
specific source files that define what is needed. Also replace all
`export *` patterns in `@ember` packages with explicit named exports.
- Update ~40 source files to import from specific lib paths instead of
barrel `index.ts` files
- Replace `export *` with named exports in `@ember/-internals/environment`,
`@ember/engine/parent`, `@ember/template-compiler/*`, `ember-template-compiler`,
and `ember-testing`
- Replace `import * as environment` with named `{ hasDOM }` import in
`@ember/application/instance`
- Add deep import path entries to `@ember/-internals/package.json` exports map
- Add `@glimmer/opcode-compiler` dependency to `ember-template-compiler`
Test files are intentionally left unchanged as they may use barrel imports.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
📊 Package size report 0.2%↑
Show files (49 files)
🤖 This report was automatically generated by pkg-size-action |
| toEnvironment(): BootEnvironment { | ||
| // Do we really want to assign all of this!? | ||
| return { | ||
| ...environment, |
Contributor
There was a problem hiding this comment.
was this totally redundant?
Contributor
Author
There was a problem hiding this comment.
Yes — ...environment was spreading { hasDOM, window, location, history, userAgent, isChrome, isFirefox } from @ember/-internals/browser-environment, but the BootEnvironment type only uses hasDOM, isInteractive, _renderMode, and options. The explicit hasDOM: this.isBrowser was already overriding it. The other properties (window, location, etc.) were not in the type and not used by any consumer.
| @@ -1,6 +1,6 @@ | |||
| export { | |||
| Helper as default, | |||
| default as default, | |||
Contributor
There was a problem hiding this comment.
can just be default, ya
Contributor
Author
There was a problem hiding this comment.
Fixed — export { default } in the latest push on #21286.
| export { setComponentTemplate, getComponentTemplate } from '@glimmer/manager'; | ||
|
|
||
| export { Component as default, Input, Textarea } from '@ember/-internals/glimmer'; | ||
| export { default as default } from '@ember/-internals/glimmer/lib/component'; |
Contributor
There was a problem hiding this comment.
can just be export { default }, yea?
Contributor
Author
There was a problem hiding this comment.
Fixed — export { default } in the latest push on #21286.
5 tasks
Contributor
|
as expected, there are a few more shared-chunks now (good)
|
NullVoxPopuli
approved these changes
Apr 4, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@ember/-internals/glimmer,@ember/-internals/environment, etc.) with direct imports from specific source files to improve tree-shakingexport *patterns in@emberpackages with explicit namedexport { ... }statementsimport * as environmentwith named imports in@ember/application/instance@ember/-internals/package.jsonexports map for the new import paths@glimmer/opcode-compileras an explicit dependency ofember-template-compilerThis enables bundlers to tree-shake more effectively since importing from a barrel
index.tspulls in all transitive dependencies. Test files are intentionally left unchanged.Barrel
index.tsfiles themselves are preserved as the public API entry points -- only their consumers are updated.Test plan
pnpm run type-check:internals) -- only pre-existing type-test errors remainpnpm run lint:eslint)pnpm run lint:format)pnpm run build:js)🤖 Generated with Claude Code