-
Notifications
You must be signed in to change notification settings - Fork 897
[Flyouts] Enhancements for Flyout Menu actions #9856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 15 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
78efb04
plan for flyout menu action follow-up
tsullivan 5f38af6
support for leading and trailing actions / control-group dividers
tsullivan d0e7309
fix for https://github.com/elastic/eui/issues/9304
tsullivan 9c33a0f
improve tests
tsullivan 0f7dd11
fix action icons height baseline
tsullivan 35023e2
cleanup
tsullivan b1f1f06
pagination fixes
tsullivan bd1471e
high contrast fixes
tsullivan 36ae2ed
jump-style pagination mode
tsullivan 9d9b2f0
chore(eui): add VRT baseline screenshots
kibanamachine 73bc634
cleanup
tsullivan d78678d
Merge branch 'flyouts/menu-actions-work' of github.com:tsullivan/eui β¦
tsullivan 182ef8a
cleanup
tsullivan 2632a1c
i18ntokens
tsullivan a38761d
cleanup
tsullivan 458d892
chore(eui): update VRT baseline screenshots
kibanamachine 4d293df
chore(eui): update VRT baseline screenshots
kibanamachine af137fb
Merge branch 'flyouts/menu-actions-work' of github.com:tsullivan/eui β¦
tsullivan ad581ad
Merge branch 'main' into flyouts/menu-actions-work
tsullivan 75fef81
storybook description terminology
tsullivan 520eb7e
remove hash router link from doc
tsullivan a8d45b0
disable hideTitle and hideCloseButton in story argTypes
tsullivan 6914089
enforce comment etiquette
tsullivan 3c0e2d7
plainer typing
tsullivan 2c78cfe
updates from feedback
tsullivan 97b4395
Merge branch 'flyouts/menu-actions-work' of github.com:tsullivan/eui β¦
tsullivan 81989f1
fix tests
tsullivan 19b992e
clean up unrelated VRT artifact
tsullivan 324a71b
split up large flyout_menu component
tsullivan 5b44212
cleanup hide title and hide close button
tsullivan 235d974
post menu component split up: centralize translation strings
tsullivan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
-26 Bytes
(100%)
packages/eui/.vrt/reference/layout-euiflyout-euiflyout--playground-desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+30 Bytes
(100%)
packages/eui/.vrt/reference/layout-euiflyout-euiflyout--playground-mobile.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+12 Bytes
(100%)
packages/eui/.vrt/reference/layout-euiflyout-euiflyout--push-flyouts-desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+25 Bytes
(100%)
packages/eui/.vrt/reference/layout-euiflyout-euiflyout--push-flyouts-mobile.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+187 Bytes
(100%)
...i/.vrt/reference/layout-euiflyout-euiflyoutmenu--pagination-example-desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+138 Bytes
(100%)
...ui/.vrt/reference/layout-euiflyout-euiflyoutmenu--pagination-example-mobile.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+17.5 KB
packages/eui/.vrt/reference/layout-euiflyout-euiflyoutmenu--playground-desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+12.6 KB
packages/eui/.vrt/reference/layout-euiflyout-euiflyoutmenu--playground-mobile.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+110 Bytes
(100%)
...tent-euidatagrid-toolbarvisibility-prop--toolbar-visibility-options-desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| - Updated `EuiFlyoutMenu`: | ||
| - Added `leadingActions` and `trailingActions` props, which accept the new `EuiFlyoutMenuAction` type supporting `toolTipContent` and `toolTipProps` | ||
| - Changed the history trigger icon to `clockCounter` | ||
| - Added control-group dividers between built-in controls | ||
| - Added `previousIconType` and `nextIconType` to `pagination`, so consumers can override the default up/down chevrons with any icon type | ||
| - Added `onFirst`, `onLast`, `firstIconType`, and `lastIconType` to `pagination`, which render optional buttons for jumping to the beginning and end of the list. | ||
|
|
||
| **Bug fixes** | ||
|
|
||
| - The `EuiFlyoutMenu` history popover now only appears when `historyItems` has more than one entry. When there is a single entry in history, only the Back button is shown. | ||
| - Fixed `EuiFlyoutMenu` pagination controls disappearing when `pagination.total` is `1`; the controls now render (as "1 of 1" with both Prev/Next disabled) for any `total` of at least `1` | ||
|
|
||
| **Deprecations** | ||
|
|
||
| - Deprecated `customActions` and `EuiFlyoutMenuCustomAction` in `EuiFlyoutMenu`; use `trailingActions` and `EuiFlyoutMenuAction` instead | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tsullivan we should add this to our deprecation schedule to be removed, maybe in 3 months?