Skip to content

First attempt at breadcrumbs. #2738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LukasMansour wants to merge 10 commits into
base: main
Choose a base branch
from
Open

First attempt at breadcrumbs. #2738

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a97d89d
First attempt at breadcrumbs.
LukasMansour Jun 1, 2026
1284806
Second attempt at breadcrumbs.
LukasMansour Jun 22, 2026
9996ccf
URL resolving by block tag.
LukasMansour Jul 6, 2026
28e8898
Two forgotten files
LukasMansour Jul 6, 2026
33dd7b9
Fix small mistakes that fail tests
LukasMansour Jul 6, 2026
3c3640a
Fix disabled breadcrumbs, remove redundant variable.
LukasMansour Jul 13, 2026
5829859
Use breadcrumb block tag everywhere
LukasMansour Jul 13, 2026
0961bbe
Merge remote-tracking branch 'upstream/main' into link-if-not-self-br…
LukasMansour Jul 20, 2026
e389c81
Fix djangofmt with custom breadcrumb tag.
LukasMansour Jul 20, 2026
5933f3c
Small improvements to some html templates.
LukasMansour Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions evap/staff/templates/staff_base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{% extends 'base.html' %}
{% load staff_templatetags %}

{% block title %}{% translate 'Manage' %} - {{ block.super }}{% endblock %}

Expand All @@ -7,9 +8,13 @@
<ul class="breadcrumb">
{% block breadcrumb %}
{% if disable_breadcrumb_manager or not user.is_manager %}
<li class="breadcrumb-item">{% translate 'Manage' %}</li>
{% breadcrumb_item %}
{% translate 'Manage' %}
{% endbreadcrumb_item %}
{% else %}
<li class="breadcrumb-item"><a href="{% url 'staff:index' %}">{% translate 'Manage' %}</a></li>
{% breadcrumb_item_url 'staff:index' %}
{% translate 'Manage' %}
{% endbreadcrumb_item_url %}
{% endif %}
{% endblock %}
</ul>
Expand Down
14 changes: 8 additions & 6 deletions evap/staff/templates/staff_course_base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{% extends 'staff_semester_base.html' %}
{% load staff_templatetags %}

{% block title %}
{% if course %}
Expand All @@ -11,13 +12,14 @@

{% block breadcrumb %}
{{ block.super }}

{% if course %}
{% if disable_breadcrumb_course %}
Comment thread
LukasMansour marked this conversation as resolved.
<li class="breadcrumb-item">{{ course.name }}</li>
{% else %}
<li class="breadcrumb-item"><a href="{% url 'staff:course_edit' course.id %}">{{ course.name }}</a></li>
{% endif %}
{% breadcrumb_item_url 'staff:course_edit' course.id %}
{{ course.name }}
{% endbreadcrumb_item_url %}
{% elif evaluation.course %}
<li class="breadcrumb-item"><a href="{% url 'staff:course_edit' evaluation.course.id %}">{{ evaluation.course.name }}</a></li>
{% breadcrumb_item_url 'staff:course_edit' evaluation.course.id %}
{{ evaluation.course.name }}
{% endbreadcrumb_item_url %}
{% endif %}
{% endblock %}
6 changes: 5 additions & 1 deletion evap/staff/templates/staff_course_type_index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
{% extends 'staff_base.html' %}

{% load staff_templatetags %}
{% load static %}

{% block breadcrumb %}
{{ block.super }}
<li class="breadcrumb-item">{% translate 'Course types' %}</li>

{% breadcrumb_item %}
{% translate 'Course types' %}
{% endbreadcrumb_item %}
{% endblock %}

{% block content %}
Expand Down
10 changes: 8 additions & 2 deletions evap/staff/templates/staff_course_type_merge.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
{% extends 'staff_base.html' %}

{% load evaluation_filters %}
{% load staff_templatetags %}

{% block breadcrumb %}
{{ block.super }}
<li class="breadcrumb-item"><a href="{% url 'staff:course_type_index' %}">{% translate 'Course types' %}</a></li>
<li class="breadcrumb-item">{% translate 'Merge course types' %}</li>
{% breadcrumb_item_url 'staff:course_type_index' %}
{% translate 'Course types' %}
{% endbreadcrumb_item_url %}

{% breadcrumb_item_url 'staff:course_type_merge_selection' %}
{% translate 'Merge course types' %}
{% endbreadcrumb_item_url %}
{% endblock %}

{% block content %}
Expand Down
12 changes: 10 additions & 2 deletions evap/staff/templates/staff_course_type_merge_selection.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,17 @@
{% extends 'staff_base.html' %}

{% load staff_templatetags %}

{% block breadcrumb %}
{{ block.super }}
<li class="breadcrumb-item"><a href="{% url 'staff:course_type_index' %}">{% translate 'Course types' %}</a></li>
<li class="breadcrumb-item">{% translate 'Merge course types' %}</li>
{% breadcrumb_item_url 'staff:course_type_index' %}
{% translate 'Course types' %}
{% endbreadcrumb_item_url %}

{% breadcrumb_item %}
{% translate 'Merge course types' %}
{% endbreadcrumb_item %}

{% endblock %}

{% block content %}
Expand Down
9 changes: 7 additions & 2 deletions evap/staff/templates/staff_evaluation_base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{% extends 'staff_course_base.html' %}

{% load staff_templatetags %}
{% block title %}
{% if evaluation.name %}
{{ evaluation.name }} -
Expand All @@ -11,9 +12,13 @@
{{ block.super }}
{% if evaluation %}
{% if evaluation.name %}
<li class="breadcrumb-item">{{ evaluation.name }}</li>
{% breadcrumb_item_url 'staff:evaluation_edit' evaluation.id %}
{{ evaluation.name }}
{% endbreadcrumb_item_url %}
{% else %}
<li class="breadcrumb-item">{{ evaluation.course.name }}</li>
{% breadcrumb_item_url 'staff:evaluation_edit' evaluation.id %}
{{ evaluation.course.name }}
Comment thread
LukasMansour marked this conversation as resolved.
{% endbreadcrumb_item_url %}
{% endif %}
{% endif %}
{% endblock %}
11 changes: 9 additions & 2 deletions evap/staff/templates/staff_evaluation_textanswer_edit.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,16 @@
{% extends 'staff_evaluation_base.html' %}

{% load staff_templatetags %}
{% block breadcrumb %}
{{ block.super }}
<li class="breadcrumb-item"><a href="{% url 'staff:evaluation_textanswers' evaluation.id %}#{{ textanswer.id }}">{% translate 'Text answers' %}</a></li>
<li class="breadcrumb-item">{{ textanswer.id }}</li>

{% breadcrumb_item_url 'staff:evaluation_textanswers' evaluation.id %}
{% translate 'Text answers' %}
{% endbreadcrumb_item_url %}

{% breadcrumb_item %}
{{ textanswer.id }}
{% endbreadcrumb_item %}
{% endblock %}

{% block content %}
Expand Down
6 changes: 5 additions & 1 deletion evap/staff/templates/staff_evaluation_textanswers.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
{% extends 'staff_evaluation_base.html' %}

{% load evaluation_filters %}
{% load staff_templatetags %}

{% block breadcrumb %}
{{ block.super }}
<li class="breadcrumb-item">{% translate 'Text answers' %}</li>

{% breadcrumb_item %}
{% translate 'Text answers' %}
{% endbreadcrumb_item %}
{% endblock %}

{% block content %}
Expand Down
6 changes: 5 additions & 1 deletion evap/staff/templates/staff_exam_type_index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
{% extends 'staff_base.html' %}

{% load static %}
{% load staff_templatetags %}

{% block breadcrumb %}
{{ block.super }}
<li class="breadcrumb-item">{% translate 'Exam types' %}</li>

{% breadcrumb_item %}
{% translate 'Exam types' %}
{% endbreadcrumb_item %}
{% endblock %}

{% block content %}
Expand Down
6 changes: 5 additions & 1 deletion evap/staff/templates/staff_faq_index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
{% extends 'staff_base.html' %}

{% load static %}
{% load staff_templatetags %}

{% block breadcrumb %}
{{ block.super }}
<li class="breadcrumb-item">{% translate 'FAQ Sections' %}</li>

{% breadcrumb_item %}
{% translate 'FAQ Sections' %}
{% endbreadcrumb_item %}
{% endblock %}

{% block content %}
Expand Down
11 changes: 9 additions & 2 deletions evap/staff/templates/staff_faq_section.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,18 @@
{% extends 'staff_base.html' %}

{% load static %}
{% load staff_templatetags %}

{% block breadcrumb %}
{{ block.super }}
<li class="breadcrumb-item"><a href="{% url 'staff:faq_index' %}">{% translate 'FAQ Sections' %}</a></li>
<li class="breadcrumb-item">{{ section.title }}</li>

{% breadcrumb_item_url 'staff:faq_index' %}
{% translate 'FAQ Sections' %}
{% endbreadcrumb_item_url %}

{% breadcrumb_item %}
{{ section.title }}
{% endbreadcrumb_item %}
{% endblock %}

{% block content %}
Expand Down
7 changes: 6 additions & 1 deletion evap/staff/templates/staff_infotexts.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
{% extends 'staff_base.html' %}

{% load staff_templatetags %}

{% block breadcrumb %}
{{ block.super }}
<li class="breadcrumb-item">{% translate 'Infotexts' %}</li>

{% breadcrumb_item %}
{% translate 'Infotexts' %}
{% endbreadcrumb_item %}
{% endblock %}

{% block content %}
Expand Down
6 changes: 5 additions & 1 deletion evap/staff/templates/staff_program_index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
{% extends 'staff_base.html' %}

{% load static %}
{% load staff_templatetags %}

{% block breadcrumb %}
{{ block.super }}
<li class="breadcrumb-item">{% translate 'Programs' %}</li>

{% breadcrumb_item %}
{% translate 'Programs' %}
{% endbreadcrumb_item %}
{% endblock %}

{% block content %}
Expand Down
11 changes: 9 additions & 2 deletions evap/staff/templates/staff_program_merge.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,18 @@
{% extends 'staff_base.html' %}

{% load evaluation_filters %}
{% load staff_templatetags %}

{% block breadcrumb %}
{{ block.super }}
<li class="breadcrumb-item"><a href="{% url 'staff:program_index' %}">{% translate 'Programs' %}</a></li>
<li class="breadcrumb-item">{% translate 'Merge programs' %}</li>

{% breadcrumb_item_url 'staff:program_index' %}
{% translate 'Programs' %}
{% endbreadcrumb_item_url %}

{% breadcrumb_item %}
{% translate 'Merge programs' %}
{% endbreadcrumb_item %}
{% endblock %}

{% block content %}
Expand Down
12 changes: 10 additions & 2 deletions evap/staff/templates/staff_program_merge_selection.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,17 @@
{% extends 'staff_base.html' %}

{% load staff_templatetags %}

{% block breadcrumb %}
{{ block.super }}
<li class="breadcrumb-item"><a href="{% url 'staff:program_index' %}">{% translate 'Programs' %}</a></li>
<li class="breadcrumb-item">{% translate 'Merge programs' %}</li>

{% breadcrumb_item_url 'staff:program_index' %}
{% translate 'Programs' %}
{% endbreadcrumb_item_url %}

{% breadcrumb_item %}
{% translate 'Merge programs' %}
{% endbreadcrumb_item %}
{% endblock %}

{% block content %}
Expand Down
19 changes: 15 additions & 4 deletions evap/staff/templates/staff_questionnaire_base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,27 @@
{% extends 'staff_base.html' %}

{% load staff_templatetags %}

{% block breadcrumb %}
{{ block.super }}
{% if questionnaire %}
<li class="breadcrumb-item"><a href="{% url 'staff:questionnaire_index' %}">{% translate 'Questionnaires' %}</a></li>
{% breadcrumb_item_url 'staff:questionnaire_index' %}
{% translate 'Questionnaires' %}
{% endbreadcrumb_item_url %}

{% if disable_breadcrumb_questionnaire %}
<li class="breadcrumb-item">{{ questionnaire.name }}</li>
{% breadcrumb_item %}
{{ questionnaire.name }}
{% endbreadcrumb_item %}
{% else %}
<li class="breadcrumb-item"><a href="{% url 'staff:questionnaire_edit' questionnaire.id %}">{{ questionnaire.name }}</a></li>
{% breadcrumb_item_url 'staff:questionnaire_edit' questionnaire.id %}
{{ questionnaire.name }}
{% endbreadcrumb_item_url %}
{% endif %}
{% else %}
<li class="breadcrumb-item">{% translate 'Questionnaires' %}</li>
{% breadcrumb_item %}
{% translate 'Questionnaires' %}
{% endbreadcrumb_item %}
{% endif %}
Comment thread
LukasMansour marked this conversation as resolved.
{% endblock %}

Expand Down
7 changes: 6 additions & 1 deletion evap/staff/templates/staff_questionnaire_usage.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
{% extends 'staff_questionnaire_base.html' %}

{% load staff_templatetags %}

{% block breadcrumb %}
{{ block.super }}
<li class="breadcrumb-item">{% translate 'Usage' %}</li>

{% breadcrumb_item %}
{% translate 'Usage' %}
{% endbreadcrumb_item %}
{% endblock %}

{% block content %}
Expand Down
6 changes: 5 additions & 1 deletion evap/staff/templates/staff_questionnaire_view.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
{% extends 'staff_questionnaire_base.html' %}

{% load staff_templatetags %}

{% block breadcrumb %}
{{ block.super }}
<li class="breadcrumb-item">{% translate 'Preview' %}</li>
{% breadcrumb_item %}
{% translate 'Preview' %}
{% endbreadcrumb_item %}
{% endblock %}

{% block content %}
Expand Down
10 changes: 4 additions & 6 deletions evap/staff/templates/staff_semester_base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{% extends 'staff_base.html' %}
{% load staff_templatetags %}

{% block title %}
{% if semester %}
Expand All @@ -9,12 +10,9 @@

{% block breadcrumb %}
{{ block.super }}
<li class="breadcrumb-item">{% translate 'Semesters' %}</li>

@LukasMansour LukasMansour Jul 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would argue that the breadcrumbs look a lot better without this singular breadcrumb. This breadcrumb links to nowhere, just makes the breadcrumb bar longer and looks ugly when something clickable appears to the right of it in the breadcrumb bar.

@richardebeling richardebeling Jul 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janno42 opinions?

{% if semester %}
{% if disable_breadcrumb_semester %}
Comment thread
LukasMansour marked this conversation as resolved.
<li class="breadcrumb-item">{{ semester.name }}</li>
{% else %}
<li class="breadcrumb-item"><a href="{% url 'staff:semester_view' semester.id %}">{{ semester.name }}</a></li>
{% endif %}
{% breadcrumb_item_url 'staff:semester_view' semester.id %}
{{ semester.name }}
{% endbreadcrumb_item_url %}
{% endif %}
{% endblock %}
6 changes: 5 additions & 1 deletion evap/staff/templates/staff_semester_export.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
{% extends 'staff_semester_base.html' %}

{% load evaluation_filters static %}
{% load staff_templatetags %}

{% block breadcrumb %}
{{ block.super }}
<li class="breadcrumb-item">{% translate 'Export' %}</li>

{% breadcrumb_item %}
{% translate 'Export' %}
{% endbreadcrumb_item %}
{% endblock %}

{% block content %}
Expand Down
Loading