First attempt at breadcrumbs. - #2738
Open
LukasMansour wants to merge 10 commits into
Open
Conversation
niklasmohrin
requested changes
Jun 29, 2026
niklasmohrin
left a comment
niklasmohrin
left a comment
Member
There was a problem hiding this comment.
What do you think about #2738 (comment) ?
LukasMansour
commented
Jul 6, 2026
|
|
||
| {% block breadcrumb %} | ||
| {{ block.super }} | ||
| <li class="breadcrumb-item">{% translate 'Semesters' %}</li> |
Collaborator
Author
There was a problem hiding this comment.
I would argue that the breadcrumbs look a lot better without this singular breadcrumb. This breadcrumb links to nowhere, just makes the breadcrumb bar longer and looks ugly when something clickable appears to the right of it in the breadcrumb bar.
niklasmohrin
requested changes
Jul 13, 2026
niklasmohrin
left a comment
niklasmohrin
left a comment
Member
There was a problem hiding this comment.
Most changes look good, I have a small number of comments:
LukasMansour
force-pushed
the
link-if-not-self-breadcrumbs
branch
from
July 13, 2026 16:35
b209e2e to
3c3640a
Compare
LukasMansour
force-pushed
the
link-if-not-self-breadcrumbs
branch
from
July 13, 2026 18:15
2bb141f to
5829859
Compare
LukasMansour
force-pushed
the
link-if-not-self-breadcrumbs
branch
2 times, most recently
from
July 20, 2026 16:15
0fd089a to
02a0e02
Compare
LukasMansour
force-pushed
the
link-if-not-self-breadcrumbs
branch
from
July 20, 2026 16:26
02a0e02 to
0961bbe
Compare
richardebeling
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First attempt at doing the link-if-not-self-breadcrumbs from issue #2642 .