Skip to content

Fix issue #963 #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alan052918 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix issue #963 #964

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4808333
Fix issue #963
Alan052918 Dec 20, 2020
e8420f6
Merge branch 'master' into issues/963-not-identifying-and-rejecting-t…
dmfs Feb 6, 2021
ea8ceb3
Merge branch 'master' into issues/963-not-identifying-and-rejecting-t…
dmfs Feb 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions opentasks/src/main/java/org/dmfs/tasks/EditTaskFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,7 +678,7 @@ public void saveAndExit()

if (mValues.isInsert() || mValues.isUpdate())
{
if (TextUtils.isEmpty(TaskFieldAdapters.TITLE.get(mValues)))
if (TextUtils.isEmpty(TaskFieldAdapters.TITLE.get(mValues)) || TaskFieldAdapters.TITLE.get(mValues).trim().equals(""))

@h3xx h3xx Dec 16, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think changing to .trim().isEmpty() would be more performant; it simply checks if the length is 0.

String.isEmpty was introduced in Java 6.

{
// there is no title, try to set one from the description or check list

Expand Down Expand Up @@ -714,7 +714,7 @@ public void saveAndExit()
}
}

if (!TextUtils.isEmpty(TaskFieldAdapters.TITLE.get(mValues)) || mValues.isUpdate())
if ((!TextUtils.isEmpty(TaskFieldAdapters.TITLE.get(mValues)) && !TaskFieldAdapters.TITLE.get(mValues).trim().equals("")) || mValues.isUpdate())

@h3xx h3xx Dec 16, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think changing to .trim().isEmpty() would be more performant; it simply checks if the length is 0.

{
if (mValues.isInsert())
{
Expand Down