Fix issue #963#964
Open
Alan052918 wants to merge 3 commits into
Open
Conversation
Alan052918
force-pushed
the
issues/963-not-identifying-and-rejecting-tasks-titled-all-whitespaces-as-empty-task
branch
from
d66d56a to
4808333
Compare
…asks-titled-all-whitespaces-as-empty-task
…asks-titled-all-whitespaces-as-empty-task
h3xx
suggested changes
Dec 16, 2023
| if (mValues.isInsert() || mValues.isUpdate()) | ||
| { | ||
| if (TextUtils.isEmpty(TaskFieldAdapters.TITLE.get(mValues))) | ||
| if (TextUtils.isEmpty(TaskFieldAdapters.TITLE.get(mValues)) || TaskFieldAdapters.TITLE.get(mValues).trim().equals("")) |
There was a problem hiding this comment.
I think changing to .trim().isEmpty() would be more performant; it simply checks if the length is 0.
String.isEmpty was introduced in Java 6.
| } | ||
|
|
||
| if (!TextUtils.isEmpty(TaskFieldAdapters.TITLE.get(mValues)) || mValues.isUpdate()) | ||
| if ((!TextUtils.isEmpty(TaskFieldAdapters.TITLE.get(mValues)) && !TaskFieldAdapters.TITLE.get(mValues).trim().equals("")) || mValues.isUpdate()) |
There was a problem hiding this comment.
I think changing to .trim().isEmpty() would be more performant; it simply checks if the length is 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.