Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion MANIFEST
Original file line number Diff line number Diff line change
Expand Up @@ -71,4 +71,3 @@ t/Net-ACME2-PromiseUtil.t
t/Net-ACME2-RetryAfter.t
t/Net-ACME2-revoke.t
t/Net-ACME2.t
t/Net-ACME2_pre_rename.t
77 changes: 77 additions & 0 deletions t/Net-ACME2-Error.t
Original file line number Diff line number Diff line change
Expand Up @@ -114,4 +114,81 @@ use Net::ACME2::Error ();
);
}

# Test type() defaults to 'about:blank' when unset
{
my $err = Net::ACME2::Error->new();

is(
$err->type(),
'about:blank',
'type() defaults to about:blank',
);
}

# Test description() with known ACME URN types
{
my @known_types = (
[ 'badNonce' => qr/unacceptable anti-replay nonce/ ],
[ 'rateLimited' => qr/rate limit/ ],
[ 'unauthorized' => qr/lacks sufficient authorization/ ],
[ 'serverInternal' => qr/internal error/ ],
[ 'malformed' => qr/malformed/ ],
[ 'badCSR' => qr/unacceptable/ ],
[ 'rejectedIdentifier'=> qr/will not issue/ ],
[ 'caa' => qr/CAA/ ],
[ 'dns' => qr/DNS query/ ],
);

for my $t (@known_types) {
my ($short_type, $desc_re) = @$t;

my $err = Net::ACME2::Error->new(
type => "urn:ietf:params:acme:error:$short_type",
);

like(
$err->description(),
$desc_re,
"description() for $short_type",
);
}
}

# Test description() returns undef for unknown types
{
my $err = Net::ACME2::Error->new(
type => 'urn:ietf:params:acme:error:totallyMadeUp',
);

is( $err->description(), undef, 'description() undef for unknown type' );
}

# Test to_string() includes description for known URN types
{
my $err = Net::ACME2::Error->new(
status => 429,
type => 'urn:ietf:params:acme:error:rateLimited',
detail => 'too many requests',
);

my $str = $err->to_string();

like( $str, qr/429/, 'to_string has status' );
like( $str, qr/rateLimited/, 'to_string has type' );
like( $str, qr/rate limit/, 'to_string has description' );
like( $str, qr/too many/, 'to_string has detail' );
}

# Test subproblems() in list context enforcement
{
my $err = Net::ACME2::Error->new(
status => 400,
type => 'urn:ietf:params:acme:error:rejectedIdentifier',
);

# subproblems() requires list context
my @subs = $err->subproblems();
is( scalar @subs, 0, 'subproblems() returns empty list when none' );
}

done_testing();
23 changes: 23 additions & 0 deletions t/Net-ACME2.t
Original file line number Diff line number Diff line change
Expand Up @@ -171,4 +171,27 @@ for my $t (@alg_key) {
);
}

# Legacy aliases (create_new_account, create_new_order)
{
my $SERVER_OBJ = Test::ACME2_Server->new(
ca_class => 'MyCA',
);

my $acme = MyCA->new( key => $_P256_KEY );

my $created = $acme->create_new_account(
termsOfServiceAgreed => 1,
);

is( $created, 1, 'create_new_account() alias works' );

my $order = $acme->create_new_order(
identifiers => [
{ type => 'dns', value => 'example.com' },
],
);

isa_ok( $order, 'Net::ACME2::Order', 'create_new_order() alias works' );
}

done_testing();
130 changes: 0 additions & 130 deletions t/Net-ACME2_pre_rename.t

This file was deleted.

Loading