test: remove dead pre_rename test, add Error and alias coverage#74
Draft
test: remove dead pre_rename test, add Error and alias coverage#74
Conversation
…lias coverage Remove t/Net-ACME2_pre_rename.t — it was a strict subset of Net-ACME2.t, leftover from the create_new_account/create_new_order rename. It tested the new names, not the old aliases. Add tests for the legacy aliases (create_new_account, create_new_order) to Net-ACME2.t so they're actually verified. Expand Error.t with: - type() default to 'about:blank' - description() for 9 known ACME URN error types - description() returning undef for unknown types - to_string() including description text - subproblems() empty list behavior Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes dead test file and fills test coverage gaps in Error.pm and legacy method aliases.
Why
t/Net-ACME2_pre_rename.twas a strict subset ofNet-ACME2.t, leftover from the create_new_account/create_new_order rename. It tested the new names, not the old aliases — so the legacy aliases had zero test coverage.Error.pm'sdescription()method (which maps ACME URN types to human-readable text and feeds intoto_string()) had no direct tests.type()defaulting toabout:blankwas untested.How
t/Net-ACME2_pre_rename.t, remove from MANIFESTcreate_new_account()andcreate_new_order()alias tests toNet-ACME2.tNet-ACME2-Error.twith 16 new tests covering description(), type() defaults, and to_string() with descriptionsTesting
make testpasses. Error.t: 21 tests (was 5). Net-ACME2.t: 63 tests (was 60 non-RSA).🤖 Generated with Claude Code
Quality Report
Changes: 4 files changed, 100 insertions(+), 131 deletions(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline