Skip to content

fix: wrong error variable in copy log, remove debug fmt.Println calls #2707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fix2015 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: wrong error variable in copy log, remove debug fmt.Println calls #2707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/domain/knowledge/service/datacopy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ func (k *knowledgeSVC) copyKnowledgeDocuments(ctx context.Context, copyCtx *know
mu.Lock()
failList = append(failList, doc.ID)
mu.Unlock()
logs.CtxErrorf(ctx, "copy document failed, src document id: %d, new id: %d, err: %v", doc.ID, newID, err)
logs.CtxErrorf(ctx, "copy document failed, src document id: %d, new id: %d, err: %v", doc.ID, newID, cpErr)
return cpErr
}
return nil
Expand Down
2 changes: 0 additions & 2 deletions backend/domain/workflow/internal/nodes/batch/batch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,6 @@ func (b *Batch) Invoke(ctx context.Context, in map[string]any, opts ...nodes.Nod
stateModifier, ok := options.GetResumeIndexes()[i]
mu.Unlock()
if ok {
fmt.Println("has state modifier for ith run: ", i, ", checkpointID: ", subCheckpointID)
ithOpts = append(ithOpts, compose.WithStateModifier(stateModifier))
}
} else {
Expand Down Expand Up @@ -456,7 +455,6 @@ func (b *Batch) Invoke(ctx context.Context, in map[string]any, opts ...nodes.Nod
return nil, err
}

fmt.Println("save composite info in state within batch: ", compState)
}

if existingCState != nil && len(existingCState.Index2InterruptInfo) > 0 {
Expand Down
2 changes: 0 additions & 2 deletions backend/domain/workflow/internal/nodes/loop/loop.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,6 @@ func (l *Loop) Invoke(ctx context.Context, in map[string]any, opts ...nodes.Node
if len(options.GetResumeIndexes()) > 0 {
stateModifier, ok := options.GetResumeIndexes()[i]
if ok {
fmt.Println("has state modifier for ith run: ", i, ", checkpointID: ", checkpointID)
ithOpts = append(ithOpts, compose.WithStateModifier(stateModifier))
}
}
Expand Down Expand Up @@ -451,7 +450,6 @@ func (l *Loop) Invoke(ctx context.Context, in map[string]any, opts ...nodes.Node
return nil, err
}

fmt.Println("save composite info in state within loop: ", compState)
}

if existingCState != nil && len(existingCState.Index2InterruptInfo) > 0 {
Expand Down