fix: wrong error variable in copy log, remove debug fmt.Println calls#2707
Open
fix2015 wants to merge 1 commit into
Open
fix: wrong error variable in copy log, remove debug fmt.Println calls#2707fix2015 wants to merge 1 commit into
fix2015 wants to merge 1 commit into
Conversation
- datacopy.go was logging err instead of cpErr when a document copy failed — err was nil at that point from a previous successful call, so every copy failure logged "err: <nil>" making debugging impossible - loop.go and batch.go had fmt.Println debug statements left in production code that bypass the structured logging system and leak internal state to stdout
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two issues:
`datacopy.go` line 273 was logging `err` instead of `cpErr` when a document copy failed. At that point `err` was nil from a previous successful call, so every copy failure logged `err: ` making it impossible to debug copy issues in production.
`loop.go` and `batch.go` had `fmt.Println` debug statements left in production code. These bypass the structured logging system (`logs.CtxInfof`), can't be filtered by log level, and leak internal state info to stdout.